Restored full matrix of OS and Python versions. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 2 2
Lines 486 486
=======================================
Hits 352 352
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Test Results (py3.11 on ubuntu-22.04)48 tests 48 ✅ 1m 17s ⏱️ Results for commit 8de35f3. ♻️ This comment has been updated with latest results. |
Test Results (py3.10 on ubuntu-22.04)48 tests 48 ✅ 1m 25s ⏱️ Results for commit 8de35f3. ♻️ This comment has been updated with latest results. |
Test Results (py3.13 on ubuntu-22.04)48 tests 48 ✅ 1m 33s ⏱️ Results for commit 8de35f3. ♻️ This comment has been updated with latest results. |
Test Results (py3.12 on ubuntu-22.04)48 tests 48 ✅ 2m 28s ⏱️ Results for commit 8de35f3. ♻️ This comment has been updated with latest results. |
…calls Python 3.11+ has stricter error handling in subprocess.check_output() which causes tests to fail when vspace prompts for directory override confirmation. Solution: Add -f (force) flag to all subprocess.check_output(["vspace", ...]) calls to bypass interactive prompts in tests. Fixed 15 test files: - tests/FileOps/test_file_operations.py - tests/GridMode/test_multi_parameter.py - tests/Random/* (8 files) - tests/Vspace_* (5 files) This ensures tests run non-interactively on all Python versions (3.9-3.13). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Modified test files to include stderr=subprocess.STDOUT in subprocess.check_output() calls to capture error messages from vspace when tests fail on Python 3.11+. This will help diagnose the root cause of failures in: - test_gaussian_min_cutoff - test_gaussian_max_cutoff - test_gaussian_both_cutoffs - test_vspace_predefprior_npy - test_vspace_predefprior_txt
NumPy 2.0+ (used in Python 3.11+) no longer allows implicit conversion of 1-element arrays to scalars when assigning to array elements. This caused ValueError: 'setting an array element with a sequence' in the Gaussian and log-normal cutoff resampling code. Fixed by explicitly extracting the scalar value using [0] index for all 6 instances where np.random.normal() or np.random.lognormal() with size=1 is assigned to an array element. This resolves test failures on Python 3.11+ for: - test_gaussian_min_cutoff - test_gaussian_max_cutoff - test_gaussian_both_cutoffs - test_vspace_predefprior_npy - test_vspace_predefprior_txt All 48 tests now pass on both Python 3.9 and Python 3.11+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.