Open
Conversation
Collaborator
gorgatron1
commented
May 9, 2025
gorgatron1
commented
- per discussion w Nailbuster
- add WebLink2URL with link to game + table
- add WEBGameID with table.id (same as VPS-ID)
- add GameID with game.id
- per discussion w Nailbuster - add WebLink2URL with link to game + table - add WEBGameID with table.id (same as VPS-ID) - add GameID with game.id
gorgatron1
commented
May 9, 2025
| let tableName = GameName | ||
| if (t.edition) { | ||
| tableName += ` ${t.edition}`; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Per discussion add the edition name to the table name
gorgatron1
commented
May 9, 2025
scripts/buildDb.js
Outdated
| game.ipdbUrl?.includes(".ipdb.org/machine.cgi?id=") | ||
| ? `"${game.ipdbUrl}"` | ||
| : "", // WeblinkURL | ||
| `https://virtualpinballspreadsheet.github.io/tables?game=${game.id}&fileType=tables&fileId=${t.id}`, // WebLink2URL |
Collaborator
Author
There was a problem hiding this comment.
The URL to the table itself. Note that this isn't scrolling the page correctly but that is an issue on the front end.
Collaborator
Author
There was a problem hiding this comment.
Does this need to be quoted? Perhaps -- the ipdbUrl is quoted above
gorgatron1
commented
May 9, 2025
scripts/buildDb.js
Outdated
| ), // Tags | ||
| t.id, // VPS-ID | ||
| t.id, // WebGameID | ||
| game.id, // GameID |
Collaborator
Author
There was a problem hiding this comment.
I guess consider the naming here. GameID was also suggested as MasterID.
- add quotes on url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.