Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses code quality issues by renaming imported symbols that shadow Python built-ins. The main changes involve aliasing ConnectionError and ConnectTimeout from the requests library, and aliasing exit from the sys module to avoid conflicts with built-in names.
- Renamed
requests.ConnectionErrortoRequestsConnectionErrorandrequests.ConnectTimeouttoRequestsConnectTimeout - Renamed
sys.exittosys_exitto avoid shadowing the built-inexit() - Updated IDE configuration files to reference Python 3.14
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ephys_link/utils/startup.py | Aliased requests exceptions to avoid shadowing built-in ConnectionError |
| tests/utils/test_startup.py | Updated test code to use the aliased exception names |
| src/ephys_link/front_end/gui.py | Aliased sys.exit to avoid shadowing built-in exit() |
| .idea/misc.xml | Updated project JDK name to Python 3.14 |
| .idea/ephys-link.iml | Updated JDK reference to Python 3.14 |
| .idea/copilot.data.migration.ask2agent.xml | Added Copilot migration configuration |
| .idea/copilot.data.migration.ask.xml | Added Copilot migration configuration |
Files not reviewed (4)
- .idea/copilot.data.migration.ask.xml: Language not supported
- .idea/copilot.data.migration.ask2agent.xml: Language not supported
- .idea/ephys-link.iml: Language not supported
- .idea/misc.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Notes