fix(robotic-sentinel): security hardening and high-load resilience#57
Open
umar-robotics-virtuals wants to merge 1 commit intoVirtual-Protocol:mainfrom
Open
Conversation
- Block path traversal and allow only known offerings in seller runtime - Encode auth requestId via axios params - Add API client retry with backoff on 429/5xx - Add job queue with concurrency limit for many robots (SELLER_MAX_CONCURRENT_JOBS) - Use execFile/execFileSync for Railway vars, openUrl, openclaw cron (no shell) - Windows fallback for findSellerPid; npm audit fix; .commit-msg in gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robotic Sentinel Security & High-Load Fixes
Security hardening and high-load resilience for the ACP seller runtime. Optimized for agents like Robotic Sentinel that handle many concurrent requests from robots (health checks, security scans, audits).
Summary
npm audit fix— 0 vulnerabilitiesChanges
1. Seller runtime
loadOfferingvalidates the resolved path stays under the offerings root; rejectsofferingNamelike".."or"../etc"(offerings.ts).listOfferings(agentDirName). Unknown names rejected in REQUEST and skipped in TRANSACTION (seller.ts).SELLER_MAX_CONCURRENT_JOBS(default 5) jobs run in parallel. Extra jobs are queued. Tune viaSELLER_MAX_CONCURRENT_JOBSenv var (seller.ts).2. Auth
getAuthStatus(requestId)uses axiosparamsinstead of building the query string manually; avoids query injection (auth.ts).3. API client
client.ts).4. Shell injection removal
setVariable/deleteVariableuseexecFileSyncwith array args (railway.ts).openUrlusesexecFilewith URL as single argument (open.ts).runCliusesexecFileSync("openclaw", ["cron", ...args])instead of shell string (openclawCron.ts).5. Platform
findSellerPidfallback useswmicon Windows instead ofps/grep(config.ts)..commit-msgadded to.gitignore;npm audit fixapplied.Files changed
src/seller/runtime/offerings.tssrc/seller/runtime/seller.tssrc/lib/auth.tssrc/lib/client.tssrc/lib/config.tsfindSellerPidsrc/deploy/railway.tsexecFileSyncfor variablessrc/lib/open.tsexecFilefor openUrlsrc/lib/openclawCron.tsexecFileSyncfor cron.env.exampleSELLER_MAX_CONCURRENT_JOBSdoc.gitignore.commit-msgpackage-lock.jsonnpm audit fix