This repository was archived by the owner on May 5, 2022. It is now read-only.
Added packJavaScript task to default gulp task#181
Open
loktar00 wants to merge 1 commit intoVirtoCommerce:devfrom
Open
Added packJavaScript task to default gulp task#181loktar00 wants to merge 1 commit intoVirtoCommerce:devfrom
loktar00 wants to merge 1 commit intoVirtoCommerce:devfrom
Conversation
|
Jason Brown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Review task https://virtocommerce.atlassian.net/browse/VP-7709 has been created |
loktar00
force-pushed
the
gulp-default-task-fix
branch
2 times, most recently
from
a27e51a to
5c2c7e1
Compare
loktar00
force-pushed
the
gulp-default-task-fix
branch
from
5c2c7e1 to
9bbef7d
Compare
Author
|
Sorry for the weird commit there.. new machine git creds weren't setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the default gulp task the
scripts_dependencies.jsfile is never created, this is required to run the templates otherwise you receive an error. The default task also cleans the directory removing the file if it was there and doesn't regenerate it.This PR just adds the
packJavaScripttask which generates the above file so a user can run thedefaulttask in order to test their template changes.