Skip to content

VCST-4413: Copy and resolve native libraries#2971

Merged
artem-dudarev merged 11 commits intodevfrom
VCST-4413-runtimes
Mar 6, 2026
Merged

VCST-4413: Copy and resolve native libraries#2971
artem-dudarev merged 11 commits intodevfrom
VCST-4413-runtimes

Conversation

@artem-dudarev
Copy link
Copy Markdown
Contributor

@artem-dudarev artem-dudarev commented Dec 17, 2025

Description

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4413


Note

High Risk
Changes module probing/copy and assembly resolution behavior, including native DLL/SO loading via ResolvingUnmanagedDll; mis-resolution can cause startup/load failures or load incorrect binaries on some RIDs/architectures.

Overview
Native library support for modules. Module dependency extraction now returns both managed and native assets (Library replaces ManagedLibrary) and LoadContextAssemblyResolver registers native library paths from .deps.json and resolves them via AssemblyLoadContext.Default.ResolvingUnmanagedDll + NativeLibrary.TryLoad.

Module file copying reworked. IFileCopyPolicy gains GetTargetRelativePath, and LocalStorageModuleCatalog delegates copy decisions/target paths to it so runtimes/** native assets preserve folder structure while TPA/reference assemblies and non-allowed files are skipped; new tests (FileCopyPolicyTests) cover path mapping and copy-required logic.

Diagnostics/logging tweaks. System info now includes RuntimeIdentifier (API + UI localization/template), startup bootstrap logging reads Serilog config, and module resolver DI switches to Serilog ILogger.

Written by Cursor Bugbot for commit f44fe99. This will update automatically on new commits. Configure here.

Artifact URL:

Image tag:
ghcr.io/VirtoCommerce/platform:3.1008.0-pr-2971-f44f-vcst-4413-runtimes-f44fe99a

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.781
Timestamp: 17-12-2025T10:26:08

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.481
Timestamp: 17-12-2025T10:48:12

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.131
Timestamp: 13-01-2026T14:51:52

@artem-dudarev artem-dudarev changed the title VCST-4413: Copy files from 'runtimes' directory VCST-4413: Copy and resolve native libraries Jan 19, 2026
Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.55
Timestamp: 19-01-2026T16:06:13

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.682
Timestamp: 20-01-2026T08:14:29

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.869
Timestamp: 21-01-2026T11:12:51

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.639
Timestamp: 04-03-2026T07:40:10

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/VirtoCommerce.Platform.Modules/LoadContextAssemblyResolver.cs
Comment thread src/VirtoCommerce.Platform.Web/Startup.cs
Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.681
Timestamp: 04-03-2026T09:47:52

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.718
Timestamp: 04-03-2026T10:11:23

@artem-dudarev artem-dudarev merged commit 8acd63a into dev Mar 6, 2026
17 checks passed
@artem-dudarev artem-dudarev deleted the VCST-4413-runtimes branch March 6, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants