Poisson EET changes#7
Open
m-richards wants to merge 159 commits intoVictoriaTransport:vitmfrom
Open
Conversation
added 30 commits
May 3, 2022 21:10
…rch where they are non-increasing - re-adjust util calc. should really document this somewhere
# Conflicts: # activitysim/core/configuration/top.py # activitysim/core/interaction_sample.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've opened this pull request for visibility mainly.
This compliments #6, in that it is the extension of that to add poisson sampling and the various fixes. That said I think it's arguably easier to look at https://github.com/m-richards/activitysim/pull/1/changes
which is the diff of #7 against #6 - this is how we were thinking about these changes during development. There's a few strategies to try and clean this up / re-synchronise the VITM2 fork cleanly.
Happy to discuss / give a recommendation depending on what you want to achive and how the fork should be synced going forward.