pkg/plugin: pad missing _time rows in instant log frames#672
Open
immanuwell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: n/a
Describe Your Changes
Fix an edge case in instant log parsing.
If VictoriaLogs returns mixed rows where one row has
_timeand another one does not, the backend built a malformed frame with uneven field lengths, so Grafana just bails out.This patch pads missing
_timeper row with the same fallback time already used when_timeis missing for the whole response. Small fix, no extra behavior changes.Repro:
{"_time":"2024-02-20T14:04:27Z","_msg":"123","_stream":"{app=\"test\"}"}{"_msg":"456","_stream":"{app=\"test\"}"}go test ./pkg/plugin -run Test_parseInstantResponse -count=1frame has different field lengthsWhy this is real:
VictoriaLogs docs say logs without
_timeare ingested with the current timestamp, so mixed rows are totally possible in practice, not some weird unreachable corner.Checklist
Summary by cubic
Pads missing
_timevalues per row in instant log responses to prevent malformed frames and Grafana errors when rows mix with and without_time.parseInstantResponse, use a singlefallbackTimefromnowFunc()to fill missing per-row_time, and reuse it when the whole response lacks_time.Written for commit c634834. Summary will update on new commits.