fix(deps): update module sigs.k8s.io/controller-runtime to v0.23.1#1870
fix(deps): update module sigs.k8s.io/controller-runtime to v0.23.1#1870
Conversation
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="go.mod">
<violation number="1" location="go.mod:33">
P0: The update to `controller-runtime` v0.23.1 introduces breaking changes to the Webhook API that have not been adapted in the codebase, which will cause the build to fail.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
a5fbedf to
642f7bc
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
42f47cb to
c9ad1b0
Compare
a81ce6e to
1c544f9
Compare
|
Lets move 1.35 bump into a separate PR and tackle it there? Iiuc controller-runtime bump doesn't require 1.35 bump |
|
https://github.com/kubernetes-sigs/controller-runtime/blob/f52bbb8bb1a2275cbe90dec8d6c12d5cacb1a7de/go.mod#L26 |
|
Another workaround we can try - operator-framework/operator-lifecycle-manager#3756 |
e48cf33 to
b31caf7
Compare
b31caf7 to
30dbb71
Compare
This seems to break e2e tests after k8s bump 1.35
cbc6ae2 to
51b04ef
Compare
This PR contains the following updates:
v0.22.2→v0.23.1v0.22.1→v0.23.1Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.23.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.23.0...v0.23.1
v0.23.0Compare Source
🔆 Highlights
GetEventRecorderForrequires updating your rbac for events to use theevents.k8s.ioapiGroup rather than the `` (core) apiGroupbuilder.WebhookManagedBy(mgr).For(&corev1.Deployment{})has to be changed tobuilder.WebhookManagedBy(mgr, &appsv1.Deployment{})runtime.Object, for example fromValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error)toValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)✨ Features
🐛 Bugfixes
waitermanipulation by @fossedihelm in #3368🌱 Other
sorttoslicespackage by @dongjiang1989 in #3370📖 Documentation
README.md's compatibility matrix forv0.22.x. by @renormalize in #3392Dependencies
Added
Changed
bda5523→078029d5ec99f8→9bdfabea0af3ef→200df9985fd79d→ec3ebc5f3f2b99→589584f4c0f3b2→bc988d5cfa47c3→2d32026Removed
New Contributors
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.0...v0.23.0
Thanks to all our contributors! 😊
v0.22.5Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.4...v0.22.5
v0.22.4Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.3...v0.22.4
v0.22.3Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.22.2...v0.22.3
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.