Conversation
0e0c06f to
83738cb
Compare
1f13772 to
6fc4e41
Compare
6fc4e41 to
b4485ba
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b4485ba to
e58848e
Compare
|
I don't like putting JSON in env var, why not go with as suggested in the original report? |
e58848e to
11d5dd2
Compare
|
@cubic-dev-ai review this PR |
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
|
@vrutkovs updated implementation |
11d5dd2 to
4d131e0
Compare
| type Resource struct { | ||
| Limit struct { | ||
| Mem string | ||
| Cpu string |
There was a problem hiding this comment.
| Cpu string | |
| Mem string | |
| Cpu string | |
| EphemeralStorage string |
See https://kubernetes.io/docs/concepts/storage/ephemeral-storage/#requests-limits
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:21">
P1: Rule violated: **Changelog Review Agent**
Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| * FEATURE: [vmalertmanager](https://docs.victoriametrics.com/operator/resources/vmalertmanager/): added namespace to `--cluster.peer` arguments explicitly when `spec.clusterDomainName` is omitted and added unit tests to test this. | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `VMDistributed` CR, which helps to propagate changes to each zone without affecting global availability. Before distributed setup deployment was multistep manual action. See [#1515](https://github.com/VictoriaMetrics/operator/issues/1515). | ||
| * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/): support ability to override default stream fields for vlagent in logs collection mode. | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): added VM_CONFIG_RELOADER_EPHEMERAL_SIZE_LIMIT global variable and `spec.configReloaderEphemeralSizeLimit` parameter that allows to set emptyDir volume sizeLimit. See [#1711](https://github.com/VictoriaMetrics/operator/issues/1711). |
There was a problem hiding this comment.
P1: Rule violated: Changelog Review Agent
Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 21:
<comment>Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.</comment>
<file context>
@@ -18,6 +18,7 @@ aliases:
* FEATURE: [vmalertmanager](https://docs.victoriametrics.com/operator/resources/vmalertmanager/): added namespace to `--cluster.peer` arguments explicitly when `spec.clusterDomainName` is omitted and added unit tests to test this.
* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `VMDistributed` CR, which helps to propagate changes to each zone without affecting global availability. Before distributed setup deployment was multistep manual action. See [#1515](https://github.com/VictoriaMetrics/operator/issues/1515).
* FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/): support ability to override default stream fields for vlagent in logs collection mode.
+* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): added VM_CONFIG_RELOADER_EPHEMERAL_SIZE_LIMIT global variable and `spec.configReloaderEphemeralSizeLimit` parameter that allows to set emptyDir volume sizeLimit. See [#1711](https://github.com/VictoriaMetrics/operator/issues/1711).
* BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): previously the operator requested `nodes/proxy` RBAC permissions even though vmagent did not use them; now this permission is no longer required, reducing the default privilege footprint for users running vmagent. See [#1753](https://github.com/VictoriaMetrics/operator/issues/1753).
</file context>
4d131e0 to
64f22b7
Compare
fixes #1711
added global VM_CONFIG_RELOADER_EPHEMERAL_STORAGE_LIMIT and VM_CONFIG_RELOADER_EPHEMERAL_STORAGE_REQUEST env variables to set ephemeralStorage limit and request for all config reloaders