Skip to content

operator: added variables to configure global ephemeralStorage limits and requests#1712

Merged
vrutkovs merged 1 commit intomasterfrom
config-reloader-empty-dir-limit
Jan 28, 2026
Merged

operator: added variables to configure global ephemeralStorage limits and requests#1712
vrutkovs merged 1 commit intomasterfrom
config-reloader-empty-dir-limit

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Dec 29, 2025

fixes #1711

added global VM_CONFIG_RELOADER_EPHEMERAL_STORAGE_LIMIT and VM_CONFIG_RELOADER_EPHEMERAL_STORAGE_REQUEST env variables to set ephemeralStorage limit and request for all config reloaders

@AndrewChubatiuk AndrewChubatiuk force-pushed the config-reloader-empty-dir-limit branch from 0e0c06f to 83738cb Compare December 29, 2025 11:07
@AndrewChubatiuk AndrewChubatiuk changed the title config-reloader: added properties for config reloader emptyDir sizeLimit management config-reloader: added properties for config reloader emptyDir management Dec 29, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the config-reloader-empty-dir-limit branch 2 times, most recently from 1f13772 to 6fc4e41 Compare December 29, 2025 14:07

This comment was marked as outdated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/config/config.go Outdated
@vrutkovs
Copy link
Copy Markdown
Collaborator

I don't like putting JSON in env var, why not go with

VM_CONFIG_RELOADER_REQUEST_EPHEMERAL_STORAGE

VM_CONFIG_RELOADER_LIMIT_EPHEMERAL_STORAGE

as suggested in the original report?

@AndrewChubatiuk AndrewChubatiuk force-pushed the config-reloader-empty-dir-limit branch from e58848e to 11d5dd2 Compare January 28, 2026 11:10
@AndrewChubatiuk AndrewChubatiuk changed the title config-reloader: added properties for config reloader emptyDir management config-reloader: added properties for config reloader emptyDir sizeLimit management Jan 28, 2026
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai
Copy link
Copy Markdown
Contributor

cubic-dev-ai Bot commented Jan 28, 2026

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

@vrutkovs updated implementation

@AndrewChubatiuk AndrewChubatiuk force-pushed the config-reloader-empty-dir-limit branch from 11d5dd2 to 4d131e0 Compare January 28, 2026 11:19
Comment thread internal/config/config.go Outdated
type Resource struct {
Limit struct {
Mem string
Cpu string
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cpu string
Mem string
Cpu string
EphemeralStorage string

See https://kubernetes.io/docs/concepts/storage/ephemeral-storage/#requests-limits

Comment thread internal/config/config.go
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:21">
P1: Rule violated: **Changelog Review Agent**

Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread docs/CHANGELOG.md Outdated
* FEATURE: [vmalertmanager](https://docs.victoriametrics.com/operator/resources/vmalertmanager/): added namespace to `--cluster.peer` arguments explicitly when `spec.clusterDomainName` is omitted and added unit tests to test this.
* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `VMDistributed` CR, which helps to propagate changes to each zone without affecting global availability. Before distributed setup deployment was multistep manual action. See [#1515](https://github.com/VictoriaMetrics/operator/issues/1515).
* FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/): support ability to override default stream fields for vlagent in logs collection mode.
* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): added VM_CONFIG_RELOADER_EPHEMERAL_SIZE_LIMIT global variable and `spec.configReloaderEphemeralSizeLimit` parameter that allows to set emptyDir volume sizeLimit. See [#1711](https://github.com/VictoriaMetrics/operator/issues/1711).
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Rule violated: Changelog Review Agent

Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 21:

<comment>Changelog entry violates the Required structure: it lacks the before/after and user-visible improvement explanation and only lists the new env var/field. Add a user-centric before/after description per the rule.</comment>

<file context>
@@ -18,6 +18,7 @@ aliases:
 * FEATURE: [vmalertmanager](https://docs.victoriametrics.com/operator/resources/vmalertmanager/): added namespace to `--cluster.peer` arguments explicitly when `spec.clusterDomainName` is omitted and added unit tests to test this.
 * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `VMDistributed` CR, which helps to propagate changes to each zone without affecting global availability. Before distributed setup deployment was multistep manual action. See [#1515](https://github.com/VictoriaMetrics/operator/issues/1515).
 * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/): support ability to override default stream fields for vlagent in logs collection mode.
+* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): added VM_CONFIG_RELOADER_EPHEMERAL_SIZE_LIMIT global variable and `spec.configReloaderEphemeralSizeLimit` parameter that allows to set emptyDir volume sizeLimit. See [#1711](https://github.com/VictoriaMetrics/operator/issues/1711).
 
 * BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): previously the operator requested `nodes/proxy` RBAC permissions even though vmagent did not use them; now this permission is no longer required, reducing the default privilege footprint for users running vmagent. See [#1753](https://github.com/VictoriaMetrics/operator/issues/1753).
</file context>
Fix with Cubic

@AndrewChubatiuk AndrewChubatiuk force-pushed the config-reloader-empty-dir-limit branch from 4d131e0 to 64f22b7 Compare January 28, 2026 11:51
@AndrewChubatiuk AndrewChubatiuk changed the title config-reloader: added properties for config reloader emptyDir sizeLimit management operator: added properties for config reloader emptyDir sizeLimit management Jan 28, 2026
@AndrewChubatiuk AndrewChubatiuk changed the title operator: added properties for config reloader emptyDir sizeLimit management operator: added variables to configure global ephemeralStorage limits and requests Jan 28, 2026
@vrutkovs vrutkovs merged commit edc396e into master Jan 28, 2026
6 checks passed
@vrutkovs vrutkovs deleted the config-reloader-empty-dir-limit branch January 28, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ephemeral storage resources on VMagent's config reloader container

3 participants