Implement 1.9->1.8 command block translation#692
Open
Beaness wants to merge 1 commit into
Open
Conversation
florianreuth
requested changes
Jul 2, 2026
florianreuth
left a comment
florianreuth
left a comment
Member
There was a problem hiding this comment.
Generally a nice approach; Haven't done more in depth reviews but just stylistic stuff for now
| }); | ||
| } | ||
|
|
||
| private void registerBlockChangeWithCommandBlockStorage(final ClientboundPackets1_9 packetType) { |
Member
There was a problem hiding this comment.
These can just be inlined, the helper methods only exist in rewriter base classes to reduce duplicated code.
| } | ||
|
|
||
| private void registerMultiBlockChangeWithCommandBlockStorage(final ClientboundPackets1_9 packetType) { | ||
| protocol.registerClientbound(packetType, new PacketHandlers() { |
Member
There was a problem hiding this comment.
Same here, just inline. Also would like to prevent PacketHandlers API from being used; Just a direct wrapper -> {} lambda with passthrough instead of map (and then storing in a field e.g. final int chunkX = wrapper.passthrough(Types.INT);)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499