Skip to content

feat(proxy): Bypass SSRF protection for URL aliases #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nakamuraos merged 1 commit into from
Apr 9, 2026
Merged

feat(proxy): Bypass SSRF protection for URL aliases #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ GET /300x200,webp/mycdn:/photos/dog.jpg
GET /proxy?url=mycdn:/photos/dog.jpg&w=300
```

- Aliases bypass `PP_ALLOWED_HOSTS` (operator-controlled, implicitly trusted)
- SSRF protection (private IP blocking) still applies
- Aliases bypass `PP_ALLOWED_HOSTS` and private IP blocking.
- Base URL must be `http://` or `https://`

## Development
Expand Down
2 changes: 1 addition & 1 deletion src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pub async fn router(
cfg.max_source_bytes,
Arc::new(Allowlist::new(vec![])),
)
.with_private_ip_check(check_private),
.with_private_ip_check(false), // aliases are defined in server config, bypass SSRF
);
let alias_s3 = s3.clone().map(|x| x as Arc<dyn Fetchable>);
let alias_local = local.clone().map(|x| x as Arc<dyn Fetchable>);
Expand Down