feat: Use flutter analyze --no-fatal-infos for more sensible settings#262
feat: Use flutter analyze --no-fatal-infos for more sensible settings#262romanr wants to merge 3 commits intoVeryGoodOpenSource:mainfrom
Conversation
disable failing on info analysis output
tomarra
changed the title
tomarra
left a comment
tomarra
left a comment
There was a problem hiding this comment.
Not sure if we want this change overall. At a minimum this should be a flag that should default to true (given that its the current functionality) and possibly let someone turn it off if they need to.
That being said the best practice here would actually be to setup an analysis_options.yaml to actually exclude the specific warnings you want to skip or put those directives in the problematic files themselves.
Change to `analyze options` instead of specific parameter
tomarra
left a comment
tomarra
left a comment
There was a problem hiding this comment.
After talking with the team on this we think the best path forward for this is actually having a distinct flag for each parameter you want to enable rather then an open placeholder. This would allow for more configurability long term as well as a clear understanding of exactly what flags are getting turned on and off at a given time.
The other piece of feedback is that we are looking for a use case or reasoning behind the need for this change. Typically analyzer changes are done via the analysis_options.yaml file instead of tool flags so all the configuration is done in one spot. Is that not possible for this?
2 participants
Disable failing on info analysis output as info means suggestions and does not necessarily mean productive feedback. Discussed here.
Status
READY]
Description
Type of Change