Skip to content

chore: 0.1.0 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vgvbot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: 0.1.0 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "very-good-ai-flutter-plugin",
"version": "0.0.1",
"version": "0.1.0",
"description": "Best-practice skills for Flutter and Dart covering accessibility, BLoC, testing, theming, navigation, security, internationalization, and architecture — plus automated dart analyze and format hooks.",
"homepage": "https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin",
"repository": "https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin",
Comment on lines 1 to 6
Copy link
Copy Markdown

@claude claude bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The very-good-analysis-upgrade skill introduced in PR #57 (now being released in v0.1.0) is missing three required discoverability entries that its companion skill dart-flutter-sdk-upgrade correctly includes: no skill-specific keywords in plugin.json, absent from the README.md skills table and slash-commands list, and absent from the CLAUDE.md repository structure. Before merging this release, add keywords like very-good-analysis and analysis-upgrade to plugin.json, add the skill row to README.md, and add it to the CLAUDE.md repository structure.

Extended reasoning...

What the bug is and how it manifests

The very-good-analysis-upgrade skill was added in PR #57 and is included in the v0.1.0 release changelog. However, it did not follow the full Adding a New Skill checklist defined in CLAUDE.md. Three required artifacts are missing: (1) skill-specific keywords in plugin.json, (2) an entry in the README.md skills table and slash-commands list, and (3) an entry in the CLAUDE.md repository structure. The skill file exists at skills/very-good-analysis-upgrade/SKILL.md but is effectively invisible to users browsing documentation or AI assistants using the plugin marketplace.

The specific code path that triggers it

When a user or AI assistant looks up available skills via README.md (lines 35-41 for the skills table, lines 70-81 for the slash-commands list) or CLAUDE.md (lines 23-39 for repository structure), they will find dart-flutter-sdk-upgrade listed but no mention of very-good-analysis-upgrade. Similarly, when the plugin is indexed by keyword in a plugin marketplace (e.g., searching for analysis-upgrade or very-good-analysis), no results will match because no such keywords exist in plugin.json.

Why existing code does not prevent it

The plugin.json does contain generic keywords like lint and analyze, but these were pre-existing entries added for other skills and do not specifically represent the very-good-analysis-upgrade skill. A user searching for very_good_analysis or analysis upgrade would not find this plugin. CLAUDE.md line 66 explicitly requires updating tags in plugin.json as step 2 when adding a new skill. PR #56 (dart-flutter-sdk-upgrade) correctly added [sdk-upgrade, dart-sdk, flutter-sdk], but PR #57 added nothing equivalent.

What the impact would be

The very-good-analysis-upgrade skill is undiscoverable through normal channels. Users reading README.md would have no idea this skill exists; they would need to stumble upon the file directly in the skills/ directory. AI assistants relying on the plugin documented structure would similarly omit it from available skill suggestions. This is especially problematic for a release actively promoting this skill as a new feature.

How to fix it

Three fixes are needed before this release merges: (1) Add keywords to plugin.json such as very-good-analysis, analysis-upgrade, and optionally lint-upgrade alongside the existing sdk-upgrade group. (2) Add a row for very-good-analysis-upgrade to the README.md skills table linking to skills/very-good-analysis-upgrade/SKILL.md, and add the slash command to the slash-commands list. (3) Add skills/very-good-analysis-upgrade/ to the CLAUDE.md repository structure section.

Step-by-step proof

  1. Open plugin.json - keywords array ends at flutter-sdk (added for dart-flutter-sdk-upgrade); search for very-good-analysis yields no match.
  2. Open README.md lines 35-41 (skills table) - dart-flutter-sdk-upgrade appears at line 41; very-good-analysis-upgrade is absent.
  3. Open README.md lines 70-81 (slash-commands list) - /vgv-dart-flutter-sdk-upgrade appears at line 80; the equivalent for very-good-analysis-upgrade is absent.
  4. Open CLAUDE.md lines 23-39 (repository structure) - dart-flutter-sdk-upgrade appears at line 29; very-good-analysis-upgrade is absent.
  5. Confirm the skill file itself exists: skills/very-good-analysis-upgrade/SKILL.md is present.
  6. The omission is consistent across all three required locations, confirming CLAUDE.md checklist steps 2, 3, and 4 were skipped for PR feat(skills): add very-good-analysis-upgrade #57.

Expand Down
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "0.0.1"
".": "0.1.0"
}
28 changes: 28 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
# Changelog

## [0.1.0](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/compare/v0.0.1...v0.1.0) (2026-03-31)


Check failure on line 5 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / 📝 Markdown Quality

Multiple consecutive blank lines 

CHANGELOG.md:5 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md012.md
### Features

* adding very good ui skill ([#24](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/24)) ([99d948f](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/99d948f86f547198b11e691c07c8ff890347beea))
* release management ([#59](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/59)) ([5a56844](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/5a56844f80fdc215e1e8bcb38477c928a85b73db))
* **skills:** add dart-flutter-sdk-upgrade ([#56](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/56)) ([8ce264a](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/8ce264a94744c52157fbab53fe51ce6781ab19a7))
* **skills:** add very-good-analysis-upgrade ([#57](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/57)) ([f0028d1](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/f0028d182abfaca942b8a1b1952f9eb1b53eee5a))


Check failure on line 13 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / 📝 Markdown Quality

Multiple consecutive blank lines 

CHANGELOG.md:13 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md012.md
### Bug Fixes

* **hooks:** prevent false positives in block-cli-workarounds ([#63](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/63)) ([fc57377](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/fc573779117425598f983719b3d44f59899c1c23))
* **hooks:** warn at session start when VGV CLI is missing or outdated ([#55](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/55)) ([9da9c87](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/9da9c878e46191ddc0f3ec9d7514461385327204))


Check failure on line 19 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / 📝 Markdown Quality

Multiple consecutive blank lines 

CHANGELOG.md:19 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md012.md
### Miscellaneous Chores

* add SECURITY policy as requested by Github ([#54](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/54)) ([7d3f6b0](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/7d3f6b01a05529121235fc157be707711f7b7349))
* **deps:** bump DavidAnson/markdownlint-cli2-action from 19 to 23 ([#65](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/65)) ([60d8f55](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/60d8f55c3c9dfd8371974fdae6ddeb3e86bc57a8))

Check warning on line 23 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / ✍️ Spelling Check 

Unknown word (Anson)
* update CI with validate-skills and markdown checks ([#58](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/58)) ([6892982](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/6892982bd29b636fab56b02cb6bea911412b41cd))


Check failure on line 26 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / 📝 Markdown Quality

Multiple consecutive blank lines 

CHANGELOG.md:26 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md012.md
### Docs

* **claude-md:** add missing skills, hooks, and scripts to structure ([#52](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/issues/52)) ([91386e6](https://github.com/VeryGoodOpenSource/very_good_ai_flutter_plugin/commit/91386e62ebfd8bd05a5015a702f3ba1509cc9096))

## 0.0.1

- Initial release.

Check failure on line 33 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / 📝 Markdown Quality

Unordered list style 

CHANGELOG.md:33:1 MD004/ul-style Unordered list style [Expected: asterisk; Actual: dash] https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md004.md
Loading