Skip to content

[PLAT-6805] -- Update client to include permission grant api#62

Closed
gbiv wants to merge 8 commits into
mainfrom
update-client-with-permissions
Closed

[PLAT-6805] -- Update client to include permission grant api#62
gbiv wants to merge 8 commits into
mainfrom
update-client-with-permissions

Conversation

@gbiv
Copy link
Copy Markdown
Contributor

@gbiv gbiv commented Jul 7, 2025

Summary

Updating the client to the latest published spec.

Test Plan

Release Notes

Possible Regressions

Dependencies

Ticket

@gbiv gbiv self-assigned this Jul 7, 2025
@gbiv gbiv requested a review from a team as a code owner July 7, 2025 16:14
Copy link
Copy Markdown
Contributor

@mikemccarty-vertex mikemccarty-vertex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbiv
Copy link
Copy Markdown
Contributor Author

gbiv commented Jul 7, 2025

LGTM

Unfortunately, it's not so straight forward because of the AnyOf OneOf situation...this one will need more work

@gbiv gbiv marked this pull request as draft July 7, 2025 17:18
@mikemccarty-vertex
Copy link
Copy Markdown
Contributor

Where does AnyOf enter into it?

@gbiv
Copy link
Copy Markdown
Contributor Author

gbiv commented Jul 7, 2025

Where does AnyOf enter into it?

Yeah, I should be more clear, it's just theOneOf...looks like OneOfChangeVisibilityOpChangeMaterialOpClearMaterialOpChangeTransformOpClearTransformOpSelectOpDeselectOperationClearRenOpViewDefaultRenOpViewRenByIdOpViewRenBySuppliedIdOpViewRepByIdOpViewRepByPredefinedIdOpClearRepOp and some others.
Also something with enum -> string conversion isn't correct

@mikemccarty-vertex
Copy link
Copy Markdown
Contributor

:feelsgood:

@sonarqubecloud
Copy link
Copy Markdown

@gbiv
Copy link
Copy Markdown
Contributor Author

gbiv commented Jul 15, 2025

in favor of #63

@gbiv gbiv closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants