Fix versioning scheme for updates and SDK re-generation.#2
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 931195c7ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "README.md", | ||
| r"packageVersion=[^,]+", | ||
| f"packageVersion={version}", | ||
| 1, |
There was a problem hiding this comment.
The regeneration script says it syncs README.md, but this replacement only updates the packageVersion=... fragment in the generator command. It does not update the README sentence declaring the “current generated package version”, so after running scripts/regenerate-sdk.sh VERSION the file can immediately contain contradictory versions and mislead future releases.
Useful? React with 👍 / 👎.
| "AGENTS.md", | ||
| r"(Package version currently used during generation: `)[^`]+(`)", | ||
| lambda match: f"{match.group(1)}{version}{match.group(2)}", | ||
| 1, |
There was a problem hiding this comment.
The AGENTS sync only rewrites the package-version bullet and the packageVersion=... generator argument, but it leaves the “Preferred regeneration command” example unchanged. After the first regen, AGENTS.md will show an outdated scripts/regenerate-sdk.sh <old-version> command alongside updated version metadata, which creates an inconsistent generation contract.
Useful? React with 👍 / 👎.
1 participant
No description provided.