Conversation
…ctive folders should be shown for each group.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| return { flowNodes: nodes, flowEdges: edges } | ||
| }, [equivalence, layout.boxes, options.nestGroups, options.showNodeCards, options.maxCardsPerGroup, options.showCapIndicator, idToMeta]) |
There was a problem hiding this comment.
Missing dependencies in useMemo cause stale node data
The useMemo computing flowNodes and flowEdges uses idToPath (lines 229, 373) and verbweaverNodes (lines 230, 374) inside the callback, but these are missing from the dependency array. When nodes are updated in the store, the memoized computation won't re-run, causing node cards to display stale metadata (title, type, etc.) until another listed dependency changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Group mode to the Graph View that allows the user to create multiple sets of filters and render each on a canvas. The user can do things like create a Group by filtering for a specific tag (such as device type in a network diagram). They will see that group and any other that they wish to see.
Additionally, groups can be viewed in nesting mode so that superset Groups are rendered as containing subsets Groups.
There is also a Cards mode.
Note
Adds a fourth Graph sub-view, enabling set-based visualization and management.
Groupview (frontend/src/views/GroupView.tsx) renders filter-defined groups using React Flow; supports flat Hasse-diagram edges or nested boxes, with optional in-group node cards and soft-link edgesGroupManagerPanel.tsx(create/enable/rename/delete up to 50 groups; per-group filters) andGroupOptionsTray.tsx(nesting, show node cards, max cards, cap indicator, JSON export/import)useGroupViewStore(frontend/src/store/groupViewState.ts) with per-tab localStorage save/load and config export/importfrontend/src/utils/grouping.ts(equivalence boxes, subset cover reduction, remainders) with a lightweight spec (grouping.spec.ts)Graph.tsx; context menu variant inNodeContextMenu.tsxadds canvas "Save as PNG"; newGroupBoxNodecomponent for group boxesdocs/graph-view.mdupdated to include Group view and usage; Desktop Electron devDependency bumped to^38.7.2(lockfile updated)Written by Cursor Bugbot for commit 2dc7388. This will update automatically on new commits. Configure here.