Update, general cleanup and overall improvements by rbroderi · Pull Request #35 · VerbalExpressions/PythonVerbalExpressions

rbroderi · 2022-05-01T20:37:20Z

Update to python 3
Utilize beartype for runtime O(1) typechecking
Add type hints for mypy / beartype static type checking.
Update license to GPL v3

…essions

MatthijsBurgh

Why the archives?
Why the released version zips? These should go in the releases.
I think docs should go in a gh-pages branch

MatthijsBurgh · 2023-03-01T14:46:59Z

.github/workflows/main.yml

@@ -0,0 +1,41 @@
+# This is a basic workflow to help you get started with Actions


I would remove all the comments. When people don't understand the file, they should look at the GH documentation.

MatthijsBurgh · 2023-03-01T14:48:06Z

.github/workflows/main.yml

+on:  # yamllint disable-line rule:truthy
+  # Triggers the workflow on push or pull request events but only for the master branch
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:


Allow pushes/pr to all branches. Enough capacity to check everything.

Suggested change

on: # yamllint disable-line rule:truthy

# Triggers the workflow on push or pull request events but only for the master branch

push:

branches: [master]

pull_request:

branches: [master]

# Allows you to run this workflow manually from the Actions tab

workflow_dispatch:

on: [push, pull_request, workflow_dispatch]

MatthijsBurgh · 2023-03-01T14:48:17Z

.github/workflows/main.yml

+        run: python --version
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip


No need to update pip

MatthijsBurgh · 2023-03-01T14:48:24Z

.github/workflows/main.yml

+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v3


MatthijsBurgh · 2023-03-01T14:48:35Z

.github/workflows/main.yml

+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+        python-version: ['3.7', '3.8', '3.9', '3.10']


Extend to use 3.11 too

MatthijsBurgh · 2023-03-01T14:51:33Z

GPLv3_LICENSE.txt

@@ -0,0 +1,674 @@
+                    GNU GENERAL PUBLIC LICENSE


Just rename to LICENSE.txt

MatthijsBurgh · 2023-03-01T14:52:00Z

LICENSE.txt

@@ -0,0 +1,39 @@
+Verbal Expressions


Why two licenses?

MatthijsBurgh · 2023-03-01T14:59:05Z

README.md

@@ -1,25 +1,34 @@
-PythonVerbalExpressions
-=======================
+Verbex: Python verbal based regular expressions


Suggested change

Verbex: Python verbal based regular expressions

# Verbex: Python verbal based regular expressions

[![CI](https://github.com/VerbalExpressions/PythonVerbalExpressions/actions/workflows/main.yml/badge.svg)](https://github.com/VerbalExpressions/PythonVerbalExpressions/actions/workflows/main.yml)

[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)

[![PyPI license](https://img.shields.io/pypi/l/verbex)](https://www.gnu.org/licenses/gpl-3.0.en.html)

[![PyPI pyversions](https://img.shields.io/pypi/pyversions/verbex)](https://pypi.python.org/pypi/ansicolortags/)

[![Generic badge](https://img.shields.io/badge/mypy-typed-purple.svg)](http://mypy-lang.org/)

[![Generic badge](https://img.shields.io/badge/beartype-runtime_typed-cyan.svg)](https://github.com/beartype/beartype)

[![Generic badge](https://img.shields.io/badge/bandit-checked-magenta.svg)](https://bandit.readthedocs.io/en/latest/)

[![Generic badge](https://img.shields.io/badge/flake8-linted-yellow.svg)](https://github.com/pycqa/flake8)

## Installation

```bash

pip install Verbex

Usage

from verbex import Verbex verbex = Verbex()

Documentation

API

Examples

Testing if we have a valid URL

# Create an example of how to test for correctly formed URLs verbex = Verbex() tester = (verbex. start_of_line(). find('http'). maybe('s'). find('://'). maybe('www.'). anything_but(' '). end_of_line() ) # Create an example URL test_url = "https://www.google.com" # Test if the URL is valid if re.match(test_url.regex,test_url): print("Valid URL") # Print the generated regex print(tester) # => ^(http)(s)?(\:\/\/)(www\.)?([^\ ]*)$

Replacing strings

# Create a test string replace_me = "Replace bird with a duck" # Create an expression that looks for the word "bird" expression = Verbex().find('bird') # Compile and use the regular expression using re import re regexp = expression.compile() result_re = regexp.sub('duck', replace_me) print(result_re)

Developer setup : running the tests

python setup.py develop python setup.py test

Other implementations

You can view all implementations on VerbalExpressions.github.io

This suggestion is a bit shitty...

MatthijsBurgh · 2023-03-01T15:02:54Z

verbex/__init__.py

@@ -0,0 +1,10 @@
+try:


I am not sure we should rename the library

MatthijsBurgh · 2023-03-01T15:03:27Z

verbex/verbex.py

@@ -0,0 +1,646 @@
+"""Generate regular expressions from an easier fluent verbal form."""


By renaming the library, the entire diff is gone.

…ons < 3.10

Richard added 5 commits April 24, 2022 15:17

updated to python 3, refactored code, added typehints

d506024

removed test file

8a6cb18

updated to python 3, using beartype, overal cleanup and improvement.

5a32898

added look arounds

cb7ef0c

update readme

0bd8d37

case mentioned this pull request May 4, 2022

Add Python 3.7 support #31

Open

rbroderi and others added 24 commits May 4, 2022 20:38

Create main.yml

963c7b1

fix missing typealias for python 3.8:

7234a88

Merge branch 'master' of https://github.com/rbroderi/PythonVerbalExpr…

552c1d5

…essions

condense python version dependent imports

fa247a0

condense python version dependent imports

c74049a

Update main.yml

c639670

Update main.yml

1f461e5

condense python version dependent imports

d38fe3c

Merge branch 'master' of https://github.com/rbroderi/PythonVerbalExpr…

6e6163f

…essions

adding github actions badge

6f8f1c5

updated readme

9f4a8e4

Create GPL_LICENSE.txt

09a59fc

change name and structure as fork

8c8e673

update name in init.py

628509b

update name in init.py

eb3ce53

Update README.md

d48c248

update setup.py

ada781c

Merge branch 'master' of https://github.com/rbroderi/PythonVerbalExpr…

ccde2ac

…essions

update version to 1.0.1

9ddf7a8

push to pypi.org

ec5231f

update setup.py python versions

2950a58

updated travis.yml with python versions

b0f29e2

updated manifest.in

1298138

added documentation

38360d2

rbroderi and others added 6 commits May 8, 2022 18:00

Update README.md

8bcc875

Update README.md

cc9a299

Update README.md

161b921

Update README.md

10145fd

add pycln

fa07e9c

updated pre-commit tests

e55e48e

MatthijsBurgh mentioned this pull request Mar 1, 2023

(actions) Migrate from travis to GH actions #36

Closed

MatthijsBurgh suggested changes Mar 1, 2023

View reviewed changes

R. Broderick and others added 22 commits April 28, 2024 01:03

cleanup and move to new dev enviroment. Drop support for python versi…

7f5b797

…ons < 3.10

cleanup and move to new dev enviroment. Drop support for python versi…

1ce407a

…ons < 3.10

update readme

ff1d5a1

Update README.md

c898467

Update README.md

9436a14

Update gh_pages.yaml

3433381

update pypi workflow to publish

d40c1ee

bump version

18c63ac

add classifiers

b8c4fca

Rename LICENSE.txt to LICENSE

75e672f

Update README.md

df0e0e3

Update LICENSE

40b0bba

Update README.md

209b469

Update README.md

429f9b6

Update README.md

a71bedc

Update README.md

214583f

Update README.md

f2088f9

Update README.md

1cf8876

Update README.md

ff4b462

Update README.md

90e4d49

Update README.md

c0d2172

Update README.md

63f2027

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update, general cleanup and overall improvements#35

Update, general cleanup and overall improvements#35
rbroderi wants to merge 88 commits intoVerbalExpressions:masterfrom
rbroderi:master

rbroderi commented May 1, 2022

Uh oh!

MatthijsBurgh left a comment

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

MatthijsBurgh Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,41 @@
		# This is a basic workflow to help you get started with Actions

-Verbex: Python verbal based regular expressions
+# Verbex: Python verbal based regular expressions
+[![CI](https://github.com/VerbalExpressions/PythonVerbalExpressions/actions/workflows/main.yml/badge.svg)](https://github.com/VerbalExpressions/PythonVerbalExpressions/actions/workflows/main.yml)
+[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
+[![PyPI license](https://img.shields.io/pypi/l/verbex)](https://www.gnu.org/licenses/gpl-3.0.en.html)
+[![PyPI pyversions](https://img.shields.io/pypi/pyversions/verbex)](https://pypi.python.org/pypi/ansicolortags/)
+[![Generic badge](https://img.shields.io/badge/mypy-typed-purple.svg)](http://mypy-lang.org/)
+[![Generic badge](https://img.shields.io/badge/beartype-runtime_typed-cyan.svg)](https://github.com/beartype/beartype)
+[![Generic badge](https://img.shields.io/badge/bandit-checked-magenta.svg)](https://bandit.readthedocs.io/en/latest/)
+[![Generic badge](https://img.shields.io/badge/flake8-linted-yellow.svg)](https://github.com/pycqa/flake8)
+## Installation
+```bash
+pip install Verbex

		@@ -0,0 +1,646 @@
		"""Generate regular expressions from an easier fluent verbal form."""

Conversation

rbroderi commented May 1, 2022

Uh oh!

MatthijsBurgh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Usage

Documentation

Examples

Testing if we have a valid URL

Replacing strings

Developer setup : running the tests

Other implementations

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants