Revert "Merge pull request #269 from maelvls/reset-before-request" #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
requested review from
EduardoVV,
luispresuelVenafi,
marcos-albornoz and
rvelaVenafi
as code owners
luispresuelVenafi
approved these changes
Feb 8, 2023
rvelaVenafi
approved these changes
Feb 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 240fe8f, reversing changes made to e607e30.
In #269 we added a call to the TPP reset endpoint to reset a certificate in case a new CSR is submitted and the old certificate was in an error state.
@maelvls found that there is a race condition in TPP (#273) that results in the reset action removing the newly requested CSR, making TPP incorrectly fallback to the previous CSR that was submitted.
Since this behaviour further complicates debugging a situation in which an error occurs, we want to revert this commit.
CC @achuchev