Skip to content

Consumers can now request private keys (for SSH certificates) protected by a passphrase #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achuchev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Consumers can now request private keys (for SSH certificates) protected by a passphrase #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/certificate/certificate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ type SshCertRequest struct {
Guid string
IncludePrivateKeyData bool
PrivateKeyPassphrase string
PrivateKeyFormat string
IncludeCertificateDetails bool

Timeout time.Duration
Expand Down Expand Up @@ -262,7 +261,6 @@ type TppSshCertRetrieveRequest struct {
DN string
IncludePrivateKeyData bool
PrivateKeyPassphrase string
PrivateKeyFormat string
IncludeCertificateDetails bool
}

Expand Down
4 changes: 4 additions & 0 deletions pkg/venafi/tpp/sshCertUtils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ func convertToSshCertReq(req *certificate.SshCertRequest) certificate.TPPSshCert
tppSshCertReq.ForceCommand = req.ForceCommand
}

if req.PrivateKeyPassphrase != "" {
tppSshCertReq.PrivateKeyPassphrase = req.PrivateKeyPassphrase
}

tppSshCertReq.IncludePrivateKeyData = true
tppSshCertReq.IncludeCertificateDetails = true

Expand Down