feat(bookstack-agent): stream tokens in real time instead of buffering#101
Merged
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The BookStack agent response was loading in one shot — the user saw nothing until the entire LLM response was ready, then everything appeared at once.
Root cause:
ask_stream()was silently consuming the entire Anthropic streaming response into memory (accumulating all tokens, waiting forget_final_message()), and only then emitting events. The character-by-character loop at the end was fast synchronous Python iteration over an already-complete string, so alltext_chunkevents flushed together in a single TCP write.Fix
src/aieng_bot/bookstack/agent.py: Yieldtext_chunkevents as tokens arrive from the streaming API instead of buffering. When acontent_block_startfor atool_useblock is detected and text was already streamed (reasoning/planning text from the model), emittext_clearto tell the UI to discard it. Theanswerevent is emitted at the end as the authoritative complete text.tests/bookstack/test_agent.py: Add_make_tool_use_block_start_eventhelper and a new testtest_stream_text_clear_emitted_when_text_precedes_tool_callcovering the discard path.The UI already handled both
text_chunkandtext_clearevents — no frontend changes needed.Test plan
pytest tests/bookstack/test_agent.py)text_clear) when the model calls a tool