fix: correct SayHookAction exact field type to string | string[]#40
Open
ghost wants to merge 1 commit into
Open
fix: correct SayHookAction exact field type to string | string[]#40ghost wants to merge 1 commit into
ghost wants to merge 1 commit into
Conversation
…wn> to string | string[]
d894d97 to
234d7a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exactfield onSayHookActionwas incorrectly typed asRecord<string, unknown> | undefinedinstead ofstring | string[] | undefined, forcing TypeScript users to cast manually when using the hook-based say API.exactinSayHookActiontostring | string[] | undefined, consistent withSayPhoneNumberHookActionwhich correctly typesexact: string.SayHookAction.tsto.fernignoreto prevent the fix from being overwritten by future Fern code generation until the upstream API definition is corrected.Root Cause
The types are auto-generated by Fern from the API definition. The Fern generator incorrectly produced
Record<string, unknown>for what should be astring | string[]union type. Since the Fern definition source is not in this repository, the fix is applied directly to the generated output and protected via.fernignore.Linear Issue
PRO-3057
Test Plan
tests/unit/types/SayHookAction.test.tswith 4 test cases covering: string value, string array value, undefined value, and combined prompt+exact usagestringassignment to the oldRecord<string, unknown>type (confirming the bug)stringandstring[]assignments after the fixChanges
src/api/types/SayHookAction.tsexacttype:Record<string, unknown>->string | string[].fernignoreSayHookAction.ts+ test file to prevent Fern overwritetests/unit/types/SayHookAction.test.ts