Skip to content

[Crash] win32u/vulkan: Move 'features' to function scope in vkCreateDevice. #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanomatters wants to merge 1 commit into
base: proton_11.0
Choose a base branch
from
Open

[Crash] win32u/vulkan: Move 'features' to function scope in vkCreateDevice. #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dlls/win32u/vulkan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,7 @@ static VkResult win32u_vkCreateDevice( VkPhysicalDevice client_physical_device,
unsigned int queue_count, props_count, i;
struct vulkan_device *device;
struct mempool pool = {0};
VkPhysicalDeviceFeatures features = {0};
VkResult res;

if (TRACE_ON(vulkan))
Expand All @@ -915,8 +916,7 @@ static VkResult win32u_vkCreateDevice( VkPhysicalDevice client_physical_device,
device->queues = (void *)(device + 1);
device->queue_props = (void *)(device->queues + queue_count);

{
VkPhysicalDeviceFeatures features = {0};
{
VkPhysicalDeviceFeatures2 *features2;

/* Enable shaderStorageImageWriteWithoutFormat for fshack
Expand All @@ -937,7 +937,7 @@ static VkResult win32u_vkCreateDevice( VkPhysicalDevice client_physical_device,
features.shaderStorageImageWriteWithoutFormat = VK_TRUE;
create_info->pEnabledFeatures = &features;
}
}
}

if (device->extensions.has_VK_WINE_openvr_device_extensions)
{
Expand Down