[TF2] Fix never falling back to secondary on spawn#1684
Open
nosoop wants to merge 1 commit intoValveSoftware:masterfrom
Open
[TF2] Fix never falling back to secondary on spawn#1684nosoop wants to merge 1 commit intoValveSoftware:masterfrom
nosoop wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Contributor
|
I think Spy spawning with his Revolver is not that big of a deal, and probably better since most Spy players could use the hint. |
Contributor
Author
It's a notable change ("fix") in behavior, hence the callout. Whether or not the current behavior in this case is desired, I'll leave up to the maintainer(s). Open to amending the PR if they'd like. |
Contributor
Author
|
On further investigation this bug also affects Demoman with a non-weapon primary slot item and weapon (non-shield) secondary. |
|
Does this fix the Demoman A-pose bug? Because it would be a shame to see it go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A conditional in its current form attempts to switch to a secondary item only if it can't be selected.
This change fixes the typo, properly enabling the fallback to the secondary item if a primary is unavailable.
Note that taking this change in as-is results in Spy spawning with the Revolver out instead of the Knife. Possible resolutions:
SwitchToNextBestWeapon( NULL );and increase the weight of the knife inscripts/tf_weapon_knife.ctx(side effects of using this inManageRegularWeaponsare not known to me, and there may be other cases where the Revolver is preferable over the Knife)