Fix compiler warning 'has virtual functions but non-virtual destructor'#898
Open
fred-wang wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix compiler warning 'has virtual functions but non-virtual destructor'#898fred-wang wants to merge 1 commit intoValveSoftware:masterfrom
fred-wang wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Compilation currently fails when the corresponding warning is treated as an error. This commit adds virtual destructors openvr.h with empty implementation to avoid that warning. They are not made pure virtual so that derived classes are not forced to implement them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation currently fails when the corresponding warning is treated as an
error. This commit adds virtual destructors openvr.h with empty implementation
to avoid that warning. They are not made pure virtual so that derived classes
are not forced to implement them.