Remove -G "Unix Makefiles" for linux cmake commnad#1619
Remove -G "Unix Makefiles" for linux cmake commnad#1619guysoft wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
As suggested in ValveSoftware#1618 , removing flags that are not required
|
Way better, but looking at the whole Linux section in the README again, they used an actual make command |
|
You don't need to reopen a PR for this change tho xD Just add a new commit to this one. |
|
it is how it is now B) |
|
I actually like separating a new cmake command to cmake and build, because it lets you see when you got cmake working,a when the actual build fails. Its more useful when troubleshooting |
|
So do i, it does indeed help if the cmake generate and build commands are separated, im just saying that the build command they're using is not ideal. They have this there right now: When it should be this: This covers for this one rare case when there is no Makefile on the system, but some other generator is available and was picked by the previous generate command. Its still a separate command, just a more robust one. |
|
I had an issue with no make file on the system, because I didn't know from what folder to build. That actually happens to me here :) |
|
Oh xD |
As suggested in #1618 , removing flags that are not required