Fixed include problems and compilation errors#1558
Open
Maniform wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fixed include problems and compilation errors#1558Maniform wants to merge 1 commit intoValveSoftware:masterfrom
Maniform wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
- Replaced bad include definitions - Define Format function as a Windows only - Removed AssertMsg and include assert which causes problems
|
|
|
Also you missed a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested to compile on Windows 10 and Ubuntu 21.04 and it worked on both of them. I've noticed a bit too late that an other quite similar pull request has been asked here : [https://github.com//pull/1524]. I don't know if it's a problem or not.