-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix Persona 5 Strikers crashing on Intel 12th gen and newer CPUs #9141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robotman40
wants to merge
99
commits into
ValveSoftware:bleeding-edge
Choose a base branch
from
robotman40:bleeding-edge
base: bleeding-edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CW-Bug-Id: #25631
To keep SDL 2.30 old behavior until we start supporting it. CW-Bug-Id: #23185
CW-Bug-Id: #23185
CW-Bug-Id: #25520
CW-Bug-Id: #25564
This reverts commit 036b17d.
…Utils_SetConfigValue(). CW-Bug-Id: #25554
CW-Bug-Id: #25554
…gValue_t manual. CW-Bug-Id: #25554
CW-Bug-Id: #25554
…::RunCallbacks(). CW-Bug-Id: #25554
CW-Bug-Id: #25594
…t() for win64. CW-Bug-Id: #25622
WideCharToMultiByte does not null terminate if a null character is not included in the input length. CW-Bug-Id: #24534
CW-Bug-Id: #23857
CW-Bug-Id: #25676
CW-Bug-Id: #25686
…ack. CW-Bug-Id: #25730
CW-Bug-Id: #25735
CW-Bug-Id: #25738
CW-Bug-Id: #25743
CW-Bug-Id: #25745
CW-Bug-Id: #25787
CW-Bug-Id: #25789
CW-Bug-Id: #25778
d09663a to
a2ab938
Compare
0a160a8 to
b1730fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here, Persona 5 Strikers will crash on Intel 12th gen and newer CPUs due to E-Cores conflicting with its DRM, Denuvo.
So I created a patch that limits the game to using P-Cores on Intel CPUs of Alder Lake generation or newer. I tried to implement it using
WINE_CPU_TOPOLOGY, but the game exhibits the same behavior with that. So instead, I set the game to use taskset for this and it allows the game to not crash during the initial loading screen.The game still freezes after that due to missing video codecs, but when I tested this in GE-Proton, it worked on my laptop using an Intel Core i9 14900HX. So I think this patch can serve as a first step to fixing this game under regular Proton.