Add SubFile.readable #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I tried to use
hashlib.file_digestwith aSubFile, I got an error because it was looking for areadablemethod that SubFile did not yet implementWhile adding this method, I was curious why the static typing didn't find this. One reason is that many of the
SubFilemethods weren't type-annotated, but a bigger problem is that the protocol we declare does not match what we're doing in SubFile. Until Python gets its act together w.r.t. file-like objects, I propose just usingtyping.AnyDemo
In
mainIn this branch