feat: Add 5-profile controller system with Auto mode

[CasperH2O]

• Added 5 controller profiles: Native, Xbox 360, DualShock 4, Desktop, Auto
• Auto mode switches between two configurable profiles based on app focus
• Implemented hotkey cycling through all 5 profiles
• Added Auto Profile on Startup setting
• Updated ControllerPage UI with expandable Auto mode configuration
• All settings persist across application restarts

Technical changes:

• Added ControllerProfile enum to SettingsManager
• Updated LayoutManager, ControllerManager, VirtualManager for new profiles
• Modified HIDModeCommands and DesktopLayoutCommands for profile cycling
• Added HIDmode.None to HIDUtils enum
• Added resource strings for new UI elements

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced Controller Profile selector with five options: Native, Xbox 360, DualShock 4, Desktop, and Auto modes
  • Added Auto Mode configuration section with customizable profiles
  • Added option to automatically enable Auto profile on startup

• UI Enhancements

  • Redesigned Controller settings page with new profile management controls
  • Extended HID mode selector with new None option

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces a controller profile system replacing layout mode handling. It adds a new ControllerProfile enum (Native, Xbox360, DualShock4, Desktop, Auto) integrated into settings and managers, renames HIDmode.NoController to HIDmode.None, updates UI controls for profile selection and auto-mode configuration, and refactors command and manager logic to apply profiles based on foreground process context.

Changes

Cohort / File(s)	Summary
Controller Profile System HandheldCompanion/Managers/SettingsManager.cs	Added public ControllerProfile enum (Native, Xbox360, DualShock4, Desktop, Auto) and three new settings properties (ControllerProfile, AutoModeProfile1, AutoModeProfile2); removed Gamepad from LayoutModes enum.
Settings Infrastructure HandheldCompanion/Properties/Settings.Designer.cs, HandheldCompanion/Properties/Settings.settings	Added four new user-scoped settings properties with defaults: ControllerProfile (4), AutoModeProfile1 (0), AutoModeProfile2 (3), AutoProfileOnStart (false).
Localization & Resources HandheldCompanion/Properties/Resources.resx	Added 12 new resource entries for UI labels: Enum_ControllerProfile_* variants, ControllerPage_ProfileMode*, ControllerPage_AutoModeSettings*, ControllerPage_AutoModeProfile*, Enum_HIDmode_None.
Command Handlers HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs, HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs	Replaced LayoutMode handling with ControllerProfile enum; updated Execute/Update logic to cycle through profiles; added event subscriptions for settings changes; suppressed toast in DesktopLayoutCommands.
Manager Integration HandheldCompanion/Managers/ControllerManager.cs	Introduced DetermineHideState helper; integrated profile/layout-aware hide/unhide logic into SettingsManager change handlers; updated HIDmode.NoController references to HIDmode.None.
Layout Manager Enhancement HandheldCompanion/Managers/LayoutManager.cs	Added controller profile tracking, auto-mode focus heuristics (CheckProfileLayout), and profile application logic; enhanced settings change handling for ControllerProfile and AutoModeProfile* settings.
HID Mode Enum Update HandheldCompanion/Utils/HIDUtils.cs, HandheldCompanion/Targets/ViGEmTarget.cs, HandheldCompanion/Managers/VirtualManager.cs	Renamed HIDmode.NoController to HIDmode.None (value 0); shifted Xbox360Controller (→1) and DualShock4Controller (→2); updated all references across managers and targets.
Controller Settings UI HandheldCompanion/Views/Pages/ControllerPage.xaml, HandheldCompanion/Views/Pages/ControllerPage.xaml.cs	Added ComboBox controls for ControllerProfile, AutoModeProfile1, and AutoModeProfile2 with SelectionChanged handlers; expanded HID mode options to include None; added AutoModeSettings SettingsExpander.
General Settings UI HandheldCompanion/Views/Pages/SettingsPage.xaml, HandheldCompanion/Views/Pages/SettingsPage.xaml.cs	Added AutoProfileOnStart toggle switch with Toggled handler and settings propagation logic.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant UI as ControllerPage UI
    participant Handler as Event Handler
    participant SM as SettingsManager
    participant LM as LayoutManager
    participant CM as ControllerManager
    participant VM as VirtualManager

    User->>UI: Select Controller Profile
    UI->>Handler: cB_ControllerProfile_SelectionChanged
    Handler->>SM: SetProperty("ControllerProfile", value)
    SM->>SM: SettingValueChanged event
    
    SM->>LM: SettingsManager_SettingValueChanged("ControllerProfile")
    LM->>LM: ApplyControllerProfile(profile)
    LM->>LM: Configure per-profile settings
    
    SM->>CM: SettingsManager_SettingValueChanged("ControllerProfile")
    CM->>CM: DetermineHideState(profile, layoutMode)
    alt Should Hide Controller
        CM->>VM: Hide target controller
    else Should Show Controller
        CM->>VM: Unhide target controller
    end
    
    SM->>UI: SettingValueChanged event
    UI->>UI: Update SelectedIndex
    UI->>Handler: ControllerRefresh()
    Handler->>UI: Refresh UI state
    
    rect rgb(200, 220, 255)
    note over User,UI: Profile applied and UI synchronized
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

• PR #1302: Main PR and related PR both make overlapping code-level changes to controller/profile/layout handling (ControllerProfile enum, SettingsManager, LayoutManager, ControllerManager, HID/HIDmode updates).
• PR #1320: Both PRs modify controller/profile handling with changes to settings infrastructure, ControllerProfile enum, ControllerPage UI, and HID mode updates.
• PR #1284: Both PRs touch the same controller/profile and layout code paths including SettingsManager (ControllerProfile), LayoutManager, and ControllerManager.

Poem

🐰 With profiles now dancing in Native, Xbox, and Dual,
The auto mode switches when gamepad or desktop calls—
From Desktop to Desktop, through profiles we hop,
A controller companion that never will stop!
—Signed with carrot-y paws 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.56% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly describes the main change: adding a 5-profile controller system with Auto mode support, which aligns with the primary objectives of introducing multiple controller profiles and Auto mode functionality.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[CasperH2O]

Lots of empty lines here, not sure what happened.

[CasperH2O]

Why are you removing useful comments, both here and a bit up?

[coderabbitai]

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs (1)

78-96: Redundant Update() call after SetProperty.

SetProperty on line 92 triggers SettingValueChanged, which already calls Update() (line 33). The explicit Update() call on line 94 is redundant and causes double execution.

🔧 Remove redundant Update call

         ManagerFactory.settingsManager.SetProperty(SettingsName, (int)nextProfile);

-        Update();
         base.Execute(IsKeyDown, IsKeyUp, false);

HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs (1)

10-42: Bug: SettingsName mismatch causes event handler to never trigger.

SettingsName is still "LayoutMode" but all the profile logic now uses "ControllerProfile". The SettingsManager_SettingValueChanged handler (line 33-42) listens for "LayoutMode" changes but Update() reads from "ControllerProfile". This means when the user changes the controller profile, this command won't update its visual state.

🐛 Fix SettingsName to match new profile system

-private const string SettingsName = "LayoutMode";
+private const string SettingsName = "ControllerProfile";

🤖 Fix all issues with AI agents

In @HandheldCompanion/Managers/VirtualManager.cs:
- Around line 413-414: The validation mistakenly repeats the same check (mode !=
HIDmode.None && mode != HIDmode.None); update the condition to check the
intended second enum value instead of duplicating None—e.g., change it to mode
!= HIDmode.None && mode != HIDmode.NotSelected (or mode != HIDmode.NoController
if that matches your enum), so the LogManager.LogError call that references mode
is only reached when mode is neither None nor the other non-selected state.

In @HandheldCompanion/Properties/Resources.resx:
- Around line 139-141: The resource key was accidentally renamed to "S" which
breaks conventions and likely bindings; revert the key name from "S" back to a
descriptive identifier (e.g., AboutPage_About) in the Resources.resx entry and
update any code or XAML references that currently use Resources.S to use
Resources.AboutPage_About (or the chosen descriptive key) so names stay
consistent with surrounding entries and existing bindings continue to work.

In @HandheldCompanion/Utils/HIDUtils.cs:
- Around line 3-9: The HIDmode enum was reordered, shifting the previous
Xbox360Controller value from 0 to 1 and breaking upgrades; in
SettingsManager.Start() add migration logic that reads the raw persisted value
for HIDmode, detects legacy 0 values (and/or a missing/older settings version
marker), maps them to HIDmode.Xbox360Controller (value 1), updates the in-memory
setting and saves the settings, and only performs this mapping once (or when a
version flag indicates legacy data); reference HIDmode and the
SettingsManager.Start() method to locate where to implement the migration and
persist the corrected setting.

In @HandheldCompanion/Views/Pages/SettingsPage.xaml:
- Around line 130-137: The SettingsCard for Auto Profile on start currently uses
hardcoded Header/Description text; replace the Header and Description attributes
with localized resource bindings (e.g., Header="{l:Static
resx:Resources.SettingsPage_EnableAutoProfileOnStart}" and
Description="{l:Static
resx:Resources.SettingsPage_EnableAutoProfileOnStartDesc}") for the SettingsCard
that contains Toggle_AutoProfileOnStart and its Toggled handler
Toggle_AutoProfileOnStart_Toggled, and add the corresponding resource keys
SettingsPage_EnableAutoProfileOnStart and
SettingsPage_EnableAutoProfileOnStartDesc to Resources.resx with appropriate
translations.

🧹 Nitpick comments (14)

HandheldCompanion/Views/Pages/SettingsPage.xaml.cs (1)

640-700: Consider removing trailing whitespace.

The file has trailing empty lines that should be removed for cleaner formatting.

HandheldCompanion/Views/Pages/ControllerPage.xaml.cs (2)

101-115: Remove development marker comments.

The comments // ========== ADD STEP 5A HERE ========== and // ====================================== appear to be leftover development artifacts that should be removed before merging.

🧹 Remove development comments

-
-                // ========== ADD STEP 5A HERE ==========
                 case "ControllerProfile":
                     cB_ControllerProfile.SelectedIndex = Convert.ToInt32(value);
                     ControllerRefresh();
                     break;

                 case "AutoModeProfile1":
                     cB_AutoModeProfile1.SelectedIndex = Convert.ToInt32(value);
                     break;

                 case "AutoModeProfile2":
                     cB_AutoModeProfile2.SelectedIndex = Convert.ToInt32(value);
                     break;
-                    // ======================================

---

320-346: LGTM with minor cleanup needed.

The event handlers follow the established pattern in this file. Remove the development marker comments (// ========== ADD STEP 5B HERE ========== and // ======================================).

HandheldCompanion/Managers/SettingsManager.cs (2)

46-54: Remove development comments and fix misleading inline comment.

The inline comment // ← CHANGED from Gamepad is a development artifact. Additionally, consider removing it as it doesn't add value for future maintainers.

🧹 Clean up enum declaration

-// Add this new enum:
 public enum ControllerProfile
 {
-    Native = 0,       // ← CHANGED from Gamepad
+    Native = 0,
     Xbox360 = 1,
     DualShock4 = 2,
     Desktop = 3,
     Auto = 4
 }

---

83-91: Remove development comments and fix misleading inline comment.

The comment // 0 = Gamepad is inconsistent with the enum where it's now Native = 0. Update for clarity.

🧹 Clean up initialization comments

-        // ========== ADD STEP 2 CODE HERE ==========
         // Initialize controller profile settings if not set
         if (!PropertyExists("ControllerProfile"))
             SetProperty("ControllerProfile", 4); // 4 = Auto mode
         if (!PropertyExists("AutoModeProfile1"))
-            SetProperty("AutoModeProfile1", 0); // 0 = Gamepad
+            SetProperty("AutoModeProfile1", 0); // 0 = Native
         if (!PropertyExists("AutoModeProfile2"))
             SetProperty("AutoModeProfile2", 3); // 3 = Desktop
-                                                // ==========================================

HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs (2)

47-76: Remove unused parameter from Update method.

The profileMode parameter is no longer used after the refactor to ControllerProfile. The method reads the current profile directly from settings.

♻️ Remove unused parameter

-public void Update(HIDmode profileMode = HIDmode.NotSelected)
+public void Update()
 {
     ControllerProfile currentProfile = (ControllerProfile)ManagerFactory.settingsManager.GetInt("ControllerProfile");
     // ... rest of method
 }

---

10-39: Clean up development marker comments.

Remove inline comments like // ← CHANGED from "HIDmode", // ← ADD THIS EVENT SUBSCRIPTION, // ← ADD THIS METHOD, and // ← Remove the 'true'.

HandheldCompanion/Managers/LayoutManager.cs (4)

16-16: Remove unused import.

System.Threading.Tasks is imported but not used in this file.

🧹 Remove unused import

-using System.Threading.Tasks;

---

363-375: Avoid magic number casts for LayoutModes.

Using (LayoutModes)0 and (LayoutModes)1 instead of named enum values reduces readability. Since Gamepad was removed from the enum, consider defining constants or using the remaining enum values directly.

♻️ Use descriptive constants

+    // LayoutModes.Gamepad was removed; use 0 for gamepad/profile layout mode
+    private const int LayoutModeGamepad = 0;
+    private const int LayoutModeDesktop = 1;
+
     private void LayoutTimer_Elapsed(object? sender, ElapsedEventArgs e)
     {
         LayoutModes layoutMode = (LayoutModes)ManagerFactory.settingsManager.GetInt("LayoutMode");

-        if (layoutMode == (LayoutModes)0)
+        if ((int)layoutMode == LayoutModeGamepad)
         {
             if (!currentLayout.Equals(profileLayout))
                 SetActiveLayout(profileLayout);
         }
-        else if (layoutMode == (LayoutModes)1)
+        else if (layoutMode == LayoutModes.Desktop)
         {
             if (!currentLayout.Equals(desktopLayout))
                 SetActiveLayout(desktopLayout);
         }
     }

---

468-501: Hardcoded window names reduce maintainability.

The focus detection logic hardcodes window names ("MainWindow", "QuickTools", "Overlay"). Consider extracting these to constants or a configuration to improve maintainability.

♻️ Extract window names to constants

+    private static readonly string[] GamepadFocusWindows = { "MainWindow", "QuickTools" };
+    private static readonly string OverlayPrefix = "Overlay";
+
     // In CheckProfileLayout:
-    bool hcHasFocus = !string.IsNullOrEmpty(currentGamepadFocus) &&
-                     (currentGamepadFocus == "MainWindow" ||
-                      currentGamepadFocus == "QuickTools" ||
-                      currentGamepadFocus.Contains("Overlay"));
+    bool hcHasFocus = !string.IsNullOrEmpty(currentGamepadFocus) &&
+                     (GamepadFocusWindows.Contains(currentGamepadFocus) ||
+                      currentGamepadFocus.Contains(OverlayPrefix));

---

473-501: Consider reducing verbose logging in hot path.

CheckProfileLayout is called on every foreground change and focus event. The multiple LogManager.LogInformation calls may impact performance and generate excessive log output. Consider using LogDebug or adding a condition to only log when debugging is enabled.

♻️ Use LogDebug for frequent diagnostics

-            LogManager.LogInformation("=== CheckProfileLayout ===");
-            LogManager.LogInformation("currentGamepadFocus: '{0}'", currentGamepadFocus ?? "null");
-            LogManager.LogInformation("hcHasFocus: {0}", hcHasFocus);
-            LogManager.LogInformation("foregroundProcess: {0}", foregroundProcess?.Executable ?? "null");
+            LogManager.LogDebug("=== CheckProfileLayout ===");
+            LogManager.LogDebug("currentGamepadFocus: '{0}'", currentGamepadFocus ?? "null");
+            LogManager.LogDebug("hcHasFocus: {0}", hcHasFocus);
+            LogManager.LogDebug("foregroundProcess: {0}", foregroundProcess?.Executable ?? "null");

Apply the same change to all LogInformation calls within CheckProfileLayout.

HandheldCompanion/Managers/ControllerManager.cs (2)

1121-1150: Centralized hide/unhide logic is sound; avoid magic enum casts

The profile-based semantics look correct (Native always visible, explicit virtual profiles always hidden, Auto deferring to HIDmode and Desktop layout). The only fragility is layoutMode == (LayoutModes)1 – relying on the underlying numeric value makes future enum changes risky. Prefer comparing against a named member (e.g., the Desktop value) instead of (LayoutModes)1.

---

1196-1269: LayoutMode and ControllerProfile handlers correctly reuse DetermineHideState; logging could be toned down

The wiring from LayoutMode and ControllerProfile changes into DetermineHideState is clean and the targetController != null && !targetController.IsVirtual() guard plus HIDcloakonconnect check prevent accidental manipulation of virtual controllers.

The current log block around ControllerProfile (multiple LogInformation lines plus an LogError when HIDcloakonconnect is disabled) is quite verbose for a normal configuration path. Once this feature is stable, consider downgrading most of these to Debug/Trace and changing the “HIDcloakonconnect is DISABLED” message to Info/Warning so regular logs don’t get noisy.

HandheldCompanion/Views/Pages/ControllerPage.xaml (1)

165-219: Use localized resources for main Controller Profile ComboBox items

cB_ControllerProfile currently uses hard-coded strings (“Native”, “Xbox 360”, etc.), while you’ve already added Enum_ControllerProfile_* resources and use them for the Auto mode profile ComboBoxes. For localization and consistency, it would be better to reuse those resources here as well.

Suggested XAML change to use resx strings

-                    <ComboBox Name="cB_ControllerProfile" SelectionChanged="cB_ControllerProfile_SelectionChanged">
-                        <ComboBoxItem Content="Native" />
-                        <ComboBoxItem Content="Xbox 360" />
-                        <ComboBoxItem Content="DualShock 4" />
-                        <ComboBoxItem Content="Desktop" />
-                        <ComboBoxItem Content="Auto" />
-                    </ComboBox>
+                    <ComboBox Name="cB_ControllerProfile" SelectionChanged="cB_ControllerProfile_SelectionChanged">
+                        <ComboBoxItem Content="{l:Static resx:Resources.Enum_ControllerProfile_Native}" />
+                        <ComboBoxItem Content="{l:Static resx:Resources.Enum_ControllerProfile_Xbox360}" />
+                        <ComboBoxItem Content="{l:Static resx:Resources.Enum_ControllerProfile_DualShock4}" />
+                        <ComboBoxItem Content="{l:Static resx:Resources.Enum_ControllerProfile_Desktop}" />
+                        <ComboBoxItem Content="{l:Static resx:Resources.Enum_ControllerProfile_Auto}" />
+                    </ComboBox>

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c47b6c7 and b46e5f9.

📒 Files selected for processing (15)

• HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs
• HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs
• HandheldCompanion/Managers/ControllerManager.cs
• HandheldCompanion/Managers/LayoutManager.cs
• HandheldCompanion/Managers/SettingsManager.cs
• HandheldCompanion/Managers/VirtualManager.cs
• HandheldCompanion/Properties/Resources.resx
• HandheldCompanion/Properties/Settings.Designer.cs
• HandheldCompanion/Properties/Settings.settings
• HandheldCompanion/Targets/ViGEmTarget.cs
• HandheldCompanion/Utils/HIDUtils.cs
• HandheldCompanion/Views/Pages/ControllerPage.xaml
• HandheldCompanion/Views/Pages/ControllerPage.xaml.cs
• HandheldCompanion/Views/Pages/SettingsPage.xaml
• HandheldCompanion/Views/Pages/SettingsPage.xaml.cs

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2024-07-27T07:08:12.731Z

Learnt from: romracer
Repo: Valkirie/HandheldCompanion PR: 1012
File: HandheldCompanion/Devices/MSI/ClawA1M.cs:0-0
Timestamp: 2024-07-27T07:08:12.731Z
Learning: The `ClawA1M` class in the `HandheldCompanion` project has been refactored to improve readability and maintainability. Changes include the removal of `scope` as a private field, simplification by removing thread logic, encapsulation of WMI event monitoring setup and teardown in separate methods with proper exception handling, and marking `specialKeyWatcher` as nullable.

Applied to files:

• HandheldCompanion/Targets/ViGEmTarget.cs
• HandheldCompanion/Utils/HIDUtils.cs
• HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs
• HandheldCompanion/Properties/Settings.settings
• HandheldCompanion/Views/Pages/ControllerPage.xaml.cs
• HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs
• HandheldCompanion/Properties/Settings.Designer.cs
• HandheldCompanion/Managers/VirtualManager.cs
• HandheldCompanion/Managers/LayoutManager.cs
• HandheldCompanion/Managers/ControllerManager.cs
• HandheldCompanion/Views/Pages/ControllerPage.xaml

📚 Learning: 2024-07-27T07:08:12.731Z

Learnt from: MSeys
Repo: Valkirie/HandheldCompanion PR: 842
File: HandheldCompanion/Properties/Resources.Designer.cs:5125-5127
Timestamp: 2024-07-27T07:08:12.731Z
Learning: The user MSeys has indicated that the proposed revision for the `ProfilesPage_UMCMotionOnOffDesc` string in the `Resources.Designer.cs` file was incorrect. The user prefers a different wording or structure for the string description.

Applied to files:

• HandheldCompanion/Views/Pages/SettingsPage.xaml
• HandheldCompanion/Properties/Resources.resx
• HandheldCompanion/Views/Pages/ControllerPage.xaml

🧬 Code graph analysis (4)

HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs (2)

HandheldCompanion/Managers/LayoutManager.cs (1)

• SettingsManager_SettingValueChanged (566-591)

HandheldCompanion/Commands/Functions/HC/QuickOverlayCommands.cs (1)

• SettingsManager_SettingValueChanged (24-36)

HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs (3)

HandheldCompanion/Commands/Functions/HC/HIDModeCommands.cs (1)

• Update (47-76)

HandheldCompanion/Managers/ManagerFactory.cs (2)

• ManagerFactory (8-72)
• ManagerFactory (39-59)

HandheldCompanion/Managers/SettingsManager.cs (2)

• GetInt (270-273)
• SetProperty (105-152)

HandheldCompanion/Properties/Settings.Designer.cs (2)

HandheldCompanion/Properties/Resources.Designer.cs (2)

• global (22-11830)
• global (31-33)

HandheldCompanion/Managers/SettingsManager.cs (1)

• Settings (14-38)

HandheldCompanion/Views/Pages/SettingsPage.xaml.cs (1)

HandheldCompanion/Managers/SettingsManager.cs (1)

• SetProperty (105-152)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Release

🔇 Additional comments (17)

HandheldCompanion/Properties/Settings.settings (1)

359-370: LGTM! New controller profile settings added correctly.

The four new settings (ControllerProfile, AutoModeProfile1, AutoModeProfile2, AutoProfileOnStart) follow the existing pattern and have sensible defaults that align with the PR objectives.

HandheldCompanion/Views/Pages/SettingsPage.xaml.cs (2)

179-181: LGTM! AutoProfileOnStart setting propagation implemented correctly.

The setting value change handler follows the established pattern for other boolean toggle settings in this file.

---

287-293: LGTM! Toggle event handler implemented correctly.

The implementation mirrors other toggle handlers (e.g., Toggle_DesktopLayoutOnStart_Toggled) with proper IsLoaded guard and settings manager integration.

HandheldCompanion/Targets/ViGEmTarget.cs (1)

13-13: LGTM! HIDmode enum value updated correctly.

The change from HIDmode.NoController to HIDmode.None aligns with the enum refactoring described in the PR objectives.

HandheldCompanion/Managers/VirtualManager.cs (3)

45-46: LGTM! HIDmode initialization updated correctly.

The default values have been updated from HIDmode.NoController to HIDmode.None, consistent with the enum refactoring.

---

202-202: LGTM! Suspend method updated correctly.

The call to SetControllerMode(HIDmode.None) properly reflects the renamed enum value.

---

398-400: LGTM! Case statement updated correctly.

The switch case for HIDmode.None has been updated with the appropriate comment.

HandheldCompanion/Commands/Functions/HC/DesktopLayoutCommands.cs (2)

74-92: Inconsistent profile cycling behavior compared to HIDModeCommands.

DesktopLayoutCommands cycles: Native → Xbox360 → DualShock4 → Desktop → Native (skipping Auto on single press), while HIDModeCommands cycles: Native → Xbox360 → DualShock4 → Desktop → Auto → Native.

This inconsistency may confuse users. Both commands should have the same cycling sequence, or the difference should be intentional and documented.

Is skipping Auto in the single-press cycle intentional? The double-press (line 99) sets Auto, but single-press skips it.

---

111-118: IsToggled always returning true may cause UI confusion.

The comment explains this is intentional for Controller Profiles, but always returning true might not reflect the actual state correctly in the UI. Consider whether this property should track a meaningful state.

HandheldCompanion/Properties/Settings.Designer.cs (1)

1440-1487: LGTM - Auto-generated settings properties.

The new settings properties are correctly generated with appropriate defaults that align with the SettingsManager initialization logic.

HandheldCompanion/Managers/LayoutManager.cs (3)

48-56: Declared Updated event appears unused.

The Updated event and UpdatedEventHandler delegate are declared but the AI summary indicates they were "temporarily introduced then removed in the final state." Verify if these are still needed, as they're only invoked for template processing (lines 103, 328) and may not be related to the new controller profile system.

---

413-418: 1-second debounce may cause noticeable delay.

The 1000ms debounce between profile switches might cause perceptible lag when rapidly switching applications. Consider whether 500ms or less would provide a better user experience while still preventing flapping.

Is the 1-second debounce intentional? Users may notice delays when alt-tabbing between games and desktop applications.

---

400-459: ApplyControllerProfile logic looks correct.

The method properly handles Auto mode delegation, debouncing, and setting the appropriate HIDmode/HIDstatus/LayoutMode combinations for each profile type.

HandheldCompanion/Managers/ControllerManager.cs (2)

1501-1527: HIDmode.None transition maintains previous semantics

Updating from HIDmode.NoController to HIDmode.None in both WatchdogLoop (VirtualManager.SetControllerMode) and GetDefault keeps the “no emulated controller → dummy Xbox 360” behavior intact, and aligns with the new enum naming. Assuming other call sites have been similarly updated to None, this looks consistent.

Also applies to: 1967-1986

---

1711-1739: Target-controller hide/unhide on selection correctly reuses profile/layout logic

Using DetermineHideState when a new physical target is selected keeps the HID cloaking behavior consistent with the currently active ControllerProfile and LayoutMode, and preserves the Legion wireless special case for powerCycle. The guardrails (!IsPowerCycling, !controller.IsVirtual(), HIDcloakonconnect) look appropriate; no functional issues spotted here.

HandheldCompanion/Properties/Resources.resx (1)

4035-4073: New controller profile and Auto mode resources look consistent

The new Enum_ControllerProfile_*, ControllerPage_*AutoMode*, and Enum_HIDmode_None strings are named consistently with existing resources and match the new UI elements on ControllerPage.xaml. Combined with the earlier suggestion, wiring cB_ControllerProfile to these keys will give you full localization coverage for the new feature.

HandheldCompanion/Views/Pages/ControllerPage.xaml (1)

158-162: No action needed—HIDmode ↔ cB_HidMode mapping is correct

The HIDmode enum values (None = 0, Xbox360Controller = 1, DualShock4Controller = 2) already align with the ComboBox item indices (0, 1, 2), so the direct SelectedIndex ↔ enum value conversion in the code-behind works correctly. The resource key Enum_HIDmode_None is properly defined in Resources.resx.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Fix duplicate condition in validation check.

The condition mode != HIDmode.None && mode != HIDmode.None checks the same value twice, which is redundant. Based on the code context showing HIDmode.NotSelected is used elsewhere (lines 139, 262, 275, 291), this appears to be an incomplete refactoring.

The original condition likely checked for both NoController and NotSelected, but during the enum rename, both were incorrectly changed to None.

🐛 Proposed fix

                 if (vTarget is null)
                 {
-                    if (mode != HIDmode.None && mode != HIDmode.None)
+                    if (mode != HIDmode.None && mode != HIDmode.NotSelected)
                         LogManager.LogError("Failed to initialise virtual controller with HIDmode: {0}", mode);
                     return;
                 }

Alternatively, if only checking for None is sufficient:

-                    if (mode != HIDmode.None && mode != HIDmode.None)
+                    if (mode != HIDmode.None)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	if (mode != HIDmode.None && mode != HIDmode.None) // ← UPDATE
	LogManager.LogError("Failed to initialise virtual controller with HIDmode: {0}", mode);
	if (vTarget is null)
	{
	if (mode != HIDmode.None && mode != HIDmode.NotSelected)
	LogManager.LogError("Failed to initialise virtual controller with HIDmode: {0}", mode);
	return;
	}

🤖 Prompt for AI Agents

In @HandheldCompanion/Managers/VirtualManager.cs around lines 413 - 414, The
validation mistakenly repeats the same check (mode != HIDmode.None && mode !=
HIDmode.None); update the condition to check the intended second enum value
instead of duplicating None—e.g., change it to mode != HIDmode.None && mode !=
HIDmode.NotSelected (or mode != HIDmode.NoController if that matches your enum),
so the LogManager.LogError call that references mode is only reached when mode
is neither None nor the other non-selected state.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Suspicious rename of About resource key to “S”

The key data name="S" with value “About” doesn’t follow the established naming convention (e.g., AboutPage_About) and looks like an accidental rename. Unless you’ve explicitly updated all usages to reference Resources.S, this risks breaking existing bindings and makes the resource hard to understand.

I’d strongly recommend renaming this back to a descriptive key (likely AboutPage_About) to match the surrounding entries and avoid confusion.

🤖 Prompt for AI Agents

In @HandheldCompanion/Properties/Resources.resx around lines 139 - 141, The
resource key was accidentally renamed to "S" which breaks conventions and likely
bindings; revert the key name from "S" back to a descriptive identifier (e.g.,
AboutPage_About) in the Resources.resx entry and update any code or XAML
references that currently use Resources.S to use Resources.AboutPage_About (or
the chosen descriptive key) so names stay consistent with surrounding entries
and existing bindings continue to work.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

rg -n "HIDmode" --type=cs

Repository: Valkirie/HandheldCompanion

Length of output: 9651

---

🏁 Script executed:

rg -n -i "migrat|upgrade|version" --type=cs | head -30

Repository: Valkirie/HandheldCompanion

Length of output: 3159

---

🏁 Script executed:

rg -n -B3 -A3 "HIDmode\s*=" --type=cs

Repository: Valkirie/HandheldCompanion

Length of output: 6990

---

🏁 Script executed:

rg -n "class SettingsManager" --type=cs -A 20

Repository: Valkirie/HandheldCompanion

Length of output: 1879

---

🏁 Script executed:

cat -n HandheldCompanion/Properties/Settings.Designer.cs | sed -n '720,740p'

Repository: Valkirie/HandheldCompanion

Length of output: 989

---

🏁 Script executed:

rg -n "HIDmode" HandheldCompanion/Properties/Settings.Designer.cs

Repository: Valkirie/HandheldCompanion

Length of output: 202

---

🏁 Script executed:

fd "\.config$" HandheldCompanion --type f

Repository: Valkirie/HandheldCompanion

Length of output: 98

---

🏁 Script executed:

cat HandheldCompanion/App.config | grep -A 5 "HIDmode"

Repository: Valkirie/HandheldCompanion

Length of output: 244

---

🏁 Script executed:

rg -n -B5 -A15 "FirstStart\|NewUpdate" HandheldCompanion/Views/Windows/MainWindow.xaml.cs

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

rg -n "NoController" --type=cs

Repository: Valkirie/HandheldCompanion

Length of output: 718

---

🏁 Script executed:

cat -n HandheldCompanion/Views/Windows/MainWindow.xaml.cs | sed -n '90,180p'

Repository: Valkirie/HandheldCompanion

Length of output: 4164

---

🏁 Script executed:

rg -n "GetInt.*HIDmode" --type=cs -B 2 -A 2

Repository: Valkirie/HandheldCompanion

Length of output: 1608

---

🏁 Script executed:

cat -n HandheldCompanion/Managers/SettingsManager.cs | sed -n '69,150p'

Repository: Valkirie/HandheldCompanion

Length of output: 3485

---

🏁 Script executed:

rg -n "Initialize.*FirstStart\|Initialize.*NewUpdate" --type=cs -B 2 -A 10

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

fd "IDevice.cs" --type f

Repository: Valkirie/HandheldCompanion

Length of output: 106

---

🏁 Script executed:

cat -n HandheldCompanion/Devices/IDevice.cs | sed -n '1,100p' | grep -n "Initialize"

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

rg -n "public.*Initialize" HandheldCompanion/Devices/IDevice.cs -A 15

Repository: Valkirie/HandheldCompanion

Length of output: 620

---

🏁 Script executed:

cat HandheldCompanion/App.config | head -100

Repository: Valkirie/HandheldCompanion

Length of output: 3686

---

🏁 Script executed:

rg -n "NoController\|enum.*HID" --type=cs -B 2 -A 8 | head -60

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

cat -n HandheldCompanion/Utils/HIDUtils.cs

Repository: Valkirie/HandheldCompanion

Length of output: 394

---

🏁 Script executed:

git log -p --all -- HandheldCompanion/Utils/HIDUtils.cs | head -100

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

git log --oneline --all HandheldCompanion/Utils/HIDUtils.cs | head -20

Repository: Valkirie/HandheldCompanion

Length of output: 239

---

🏁 Script executed:

git log --format="%H %s" --all -- HandheldCompanion/Utils/HIDUtils.cs | head -5

Repository: Valkirie/HandheldCompanion

Length of output: 335

---

🏁 Script executed:

git show HEAD:HandheldCompanion/Utils/HIDUtils.cs 2>/dev/null || echo "File not found in HEAD"

Repository: Valkirie/HandheldCompanion

Length of output: 289

---

🏁 Script executed:

rg -n "NoController.*=" --type=cs | head -20

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

git show 7c8e61a2:HandheldCompanion/Utils/HIDUtils.cs 2>/dev/null || echo "Not found in that commit"

Repository: Valkirie/HandheldCompanion

Length of output: 297

---

🏁 Script executed:

git diff 7c8e61a2 HEAD -- HandheldCompanion/Utils/HIDUtils.cs 2>/dev/null

Repository: Valkirie/HandheldCompanion

Length of output: 517

---

🏁 Script executed:

git show 022c9cb1:HandheldCompanion/Utils/HIDUtils.cs 2>/dev/null

Repository: Valkirie/HandheldCompanion

Length of output: 275

---

🏁 Script executed:

rg -n "Xbox360Controller = 0" --type=cs

Repository: Valkirie/HandheldCompanion

Length of output: 52

---

🏁 Script executed:

git log --all --grep="HIDmode\|enum.*HID" --oneline

Repository: Valkirie/HandheldCompanion

Length of output: 719

---

Breaking change: enum value shift will corrupt legacy persisted settings.

Existing user settings with HIDmode=0 (previously Xbox360Controller) will now be interpreted as None. The default value in app.config has always been 0, so users upgrading will experience unexpected behavior where their configured emulated controller reverts to disabled.

Migration logic should be added in SettingsManager.Start() to detect and upgrade legacy values (e.g., if value is 0 and it's from an old version, map it to Xbox360Controller = 1), or document this as a breaking change requiring users to reconfigure their controller settings.

🤖 Prompt for AI Agents

In @HandheldCompanion/Utils/HIDUtils.cs around lines 3 - 9, The HIDmode enum was
reordered, shifting the previous Xbox360Controller value from 0 to 1 and
breaking upgrades; in SettingsManager.Start() add migration logic that reads the
raw persisted value for HIDmode, detects legacy 0 values (and/or a missing/older
settings version marker), maps them to HIDmode.Xbox360Controller (value 1),
updates the in-memory setting and saves the settings, and only performs this
mapping once (or when a version flag indicates legacy data); reference HIDmode
and the SettingsManager.Start() method to locate where to implement the
migration and persist the corrected setting.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Use localized resource strings instead of hardcoded text.

The new SettingsCard uses hardcoded strings for Header and Description, which is inconsistent with all other settings cards in this file that use resource references (e.g., {l:Static resx:Resources.SettingsPage_EnableDesktopLayoutOnStart}).

This breaks the application's localization pattern and prevents translation of this UI element.

🌐 Suggested fix to use resource strings

-                <!--  Auto Profile on Start  -->
-                <ui:SettingsCard Description="Automatically enable Auto profile when HandheldCompanion starts" Header="Enable Auto profile on start">
+                <!--  Enable Auto profile on start  -->
+                <ui:SettingsCard Description="{l:Static resx:Resources.SettingsPage_EnableAutoProfileOnStartDesc}" Header="{l:Static resx:Resources.SettingsPage_EnableAutoProfileOnStart}">
                     <ui:SettingsCard.HeaderIcon>
                         <ui:FontIcon FontFamily="{DynamicResource SymbolThemeFontFamily}" Glyph="&#xE9A1;" />
                     </ui:SettingsCard.HeaderIcon>

Note: You'll need to add the corresponding resource strings SettingsPage_EnableAutoProfileOnStart and SettingsPage_EnableAutoProfileOnStartDesc to your Resources.resx file.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In @HandheldCompanion/Views/Pages/SettingsPage.xaml around lines 130 - 137, The
SettingsCard for Auto Profile on start currently uses hardcoded
Header/Description text; replace the Header and Description attributes with
localized resource bindings (e.g., Header="{l:Static
resx:Resources.SettingsPage_EnableAutoProfileOnStart}" and
Description="{l:Static
resx:Resources.SettingsPage_EnableAutoProfileOnStartDesc}") for the SettingsCard
that contains Toggle_AutoProfileOnStart and its Toggled handler
Toggle_AutoProfileOnStart_Toggled, and add the corresponding resource keys
SettingsPage_EnableAutoProfileOnStart and
SettingsPage_EnableAutoProfileOnStartDesc to Resources.resx with appropriate
translations.

[CasperH2O]

This looks like an LLM note that you forgot to remove.

[CasperH2O]

This looks like an LLM note that you forgot to remove.

[CasperH2O]

This looks like an LLM note that you forgot to remove.

[CasperH2O]

I'm not super familiar with the toast manager implementation throughout the app, is it normal to do them in the methods for setting values in the settings manager?

[CasperH2O]

More LLM notes here

[CasperH2O]

More LLM notes

[CasperH2O]

More LLM notes.

[CasperH2O]

You removed a very important bit of information that was learned through manual effort.

[CasperH2O]

More removals of important commentary.

[CasperH2O]

@MistakePlaysGit are you planning on following up my comments/feedback? If not, while I agree with this feature, I'd like to close this open pull request.