Проектная работа №2#1
Open
ValentinPside wants to merge 2 commits into
Open
Conversation
Comment on lines
+9
to
+10
| private T t; | ||
|
|
There was a problem hiding this comment.
Это поле здесь никак не используется. Можно удалить.
| return newItem; | ||
| } | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
Это неиспользуемый ListDiffCallback можно удалить и так же поступить в остальных адаптерах
Comment on lines
+26
to
+30
| @Override | ||
| public boolean theSameAs(FilterContactTypeUi filterContactTypeUi) { | ||
| return this.hashCode() == filterContactTypeUi.hashCode(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Comment on lines
+26
to
+30
| @Override | ||
| public boolean theSameAs(SortTypeUI sortTypeUI) { | ||
| return this.hashCode() == sortTypeUI.hashCode(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Устранены критические замечания: - в классе FilterContactTypeUi исправлена реализация метода theSameAs() - в классе SortTypeUI исправлена реализация метода theSameAs() Дополнительно в адаптерах удалены неиспользуемые методы, которые ранее были закомментированы, а из класса BaseListDiffCallback удалена неиспользуемая переменная.
Owner
Author
|
Исправил замечания во втором комите |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Первая попытка, вроде всё работает