Dev#2
Open
ValentinPside wants to merge 2 commits into
Open
Conversation
Owner
ValentinPside
commented
Dec 28, 2022
ValentinPside
commented
- Добавлены методы hasNextInt и hasNextDouble при проверки введённых в консоль данных;
- Дублирующиеся проверки в классе Calculator выведены в отдельный метод;
- Расчёт окончания в классе Calculator проводится по новому алгоритму в отдельном методе;
gusar-off
reviewed
Dec 29, 2022
| } | ||
|
|
||
| public void setName() { | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
Лучшее переиспользовать инстанс Scanner, а не создавать каждый раз новый.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.