Switch to a JRE 23 base image on Alpine#29
Open
craigminihan wants to merge 3 commits into
Open
Conversation
... plus use a multi-stage build to remove wget from the final image
craigminihan
commented
Feb 20, 2026
| @@ -1,15 +1,24 @@ | |||
| FROM eclipse-temurin:23-jdk | |||
| FROM eclipse-temurin:25-jre-alpine AS builder | |||
Author
There was a problem hiding this comment.
Use OpenJDK JRE version 23 on Alpine, note the Dockerfile is using multi-stage builds now
craigminihan
commented
Feb 20, 2026
| RUN apt-get update | ||
| RUN apt-get install -y wget unzip jq | ||
| RUN apk update && \ | ||
| apk add wget |
Author
There was a problem hiding this comment.
only add wget since AFAIK jq and unzip aren't required??
craigminihan
commented
Feb 20, 2026
| RUN wget -q "https://github.com/Vacxe/google-play-cli-kt/releases/download/$PLAY_CLI_VERSION/google-play-cli.tar" && \ | ||
| tar -xvf "google-play-cli.tar" -C /usr/local && \ | ||
| RUN wget -q "https://github.com/Vacxe/google-play-cli-kt/releases/download/${PLAY_CLI_VERSION}/google-play-cli.tar" && \ | ||
| tar -xvf "google-play-cli.tar" -C /opt && \ |
craigminihan
commented
Feb 20, 2026
|
|
||
| RUN echo "CLI version:" && google-play-cli version | ||
| # copy the cli binaries | ||
| COPY --from=builder /opt/google-play-cli /opt/google-play-cli |
Author
There was a problem hiding this comment.
copy in the binaries from the temporary builder image
craigminihan
commented
Feb 20, 2026
| COPY --from=builder /opt/google-play-cli /opt/google-play-cli | ||
|
|
||
| # soft link the cli to /usr/local/bin and check it works ok | ||
| RUN ln -s /opt/google-play-cli/bin/google-play-cli /usr/local/bin/google-play-cli && \ |
Author
There was a problem hiding this comment.
soft link google-play-cli into /usr/local/bin which is on the path already
craigminihan
commented
Feb 20, 2026
| echo "CLI version:" && google-play-cli version | ||
|
|
||
| # set the entrypoint to the cli and default args to `--help` | ||
| ENTRYPOINT [ "google-play-cli" ] |
Author
There was a problem hiding this comment.
this is a breaking change: set the entrypoint to google-play-cli to execute automatically when docker run is used
craigminihan
changed the title
craigminihan
changed the title
craigminihan
commented
Feb 20, 2026
|
|
||
| # set the entrypoint to the cli and default args to `--help` | ||
| ENTRYPOINT [ "google-play-cli" ] | ||
| CMD [ "--help" ] |
Author
There was a problem hiding this comment.
set the default command line args to --help, if the user specifies anything else that will be used instead
craigminihan
changed the title
craigminihan
force-pushed
the
alpine-base-image
branch
from
00f2d71 to
c546aad
Compare
Owner
|
@craigminihan hey mate I'll take a look and will create a new release asap |
Owner
|
@craigminihan thanks for your contribution mate. I just have a few conerns about your PR:
I can't merge any breking compatibilities because this image is in use by AAA enterprise companies
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great project! I plan to make use of it from my GH workflows. This PR contains a few quality of life changes, so nothing critical and no new features.
I've made a number of changes to the Dockerfile as follows:
eclipse-temurin:23-jre-alpineas the base imagewgetand any other build-time tools don't end up on the final image/optrather than/usr/localand soft linkedgoogle-play-cliinto/usr/local/binwhich is on the path by defaultgoogle-play-clias theentrypointAdvantages
For example when invoking this version you'd use
docker run -ti --rm vacxe/google-play-clito see help rather thandocker run -ti --rm vacxe/google-play-cli google-play-cli --help.You can see the same approach to Dockerfile structure in the
anchore/grypeimage which is a great free image scanning tool, for example: https://github.com/anchore/grype/blob/9d54499415ad6f34426ce82082fa205a2e6bc45a/Dockerfile#L29 shows the entrypoint behaviour.