Skip to content

test: bump pytest-codspeed to v4.2.0#1194

Closed
qryxip wants to merge 1 commit intoVOICEVOX:mainfrom
qryxip:pr/test-bump-pytest-codspeed-to-v4-2-0
Closed

test: bump pytest-codspeed to v4.2.0#1194
qryxip wants to merge 1 commit intoVOICEVOX:mainfrom
qryxip:pr/test-bump-pytest-codspeed-to-v4-2-0

Conversation

@qryxip
Copy link
Copy Markdown
Member

@qryxip qryxip commented Nov 8, 2025

内容

現在CodSpeedへのアップロードが失敗し続けている (正確にはGHA側は何ら問題なく正常終了しているがCodSpeed側が拒否している)ので、原因はよくわからないがとりあえずpytest-codspeedを最新に上げてどうなるかを見てみる。

image image

関連 Issue

その他

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 8, 2025

CodSpeed Performance Report

Merging #1194 will not alter performance

Comparing qryxip:pr/test-bump-pytest-codspeed-to-v4-2-0 (35779ab) with main (fa9a1a6)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 2 untouched
⏩ 22 skipped2

Footnotes

  1. No successful run was found on main (b4766c4) during the generation of this report, so fa9a1a6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 22 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@qryxip
Copy link
Copy Markdown
Member Author

qryxip commented Nov 8, 2025

駄目か…。あ、でもCodSpeedのDiscordに何か書かれてるな (後で見る)

@GuillaumeLagrange
Copy link
Copy Markdown

Hello @qryxip !
We noticed failed runs on this repository, and I wanted to help out.

The root cause is this: https://github.com/VOICEVOX/voicevox_core/actions/runs/19197157861/job/54997761053?pr=1194#step:8:173
poetry fails to find the pyproject.toml.

The workflow itself should have failed, but we had a bug on this that we just fixed here CodSpeedHQ/codspeed@3bf0cff

When this change makes its way to the latest release, your benchmark job will fail with a proper error message, preventing the confusion. Don't hesitate to reach out if you need further help.

英語で話してすみません。しばらく日本語を話していません。

@qryxip
Copy link
Copy Markdown
Member Author

qryxip commented Nov 11, 2025

英語で話してすみません。しばらく日本語を話していません。

No worries! Thank you for helping us.

poetry fails to find the pyproject.toml

The workflow itself should have failed

I tried v4.3.4. The benchmarks succeeded and a report was correctly uploaded rather than failing with a proper error message, likely due to CodSpeedHQ/codspeed#150.

It seems that this working-directory was not respected at v4.3.3.

working-directory: ./crates/voicevox_core_python_api

@qryxip
Copy link
Copy Markdown
Member Author

qryxip commented Nov 11, 2025

Closing this PR as the problem has been resolved. I will update pytest-codspeed with other libraries.

@qryxip qryxip closed this Nov 11, 2025
@qryxip qryxip deleted the pr/test-bump-pytest-codspeed-to-v4-2-0 branch November 11, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants