Skip to content

fix(Snackbar): mode dark use ColorSchemeProvider#9834

Open
SevereCloud wants to merge 1 commit into
masterfrom
SevereCloud/fix/Snackbar/mode-dark-use-ColorSchemeProvider
Open

fix(Snackbar): mode dark use ColorSchemeProvider#9834
SevereCloud wants to merge 1 commit into
masterfrom
SevereCloud/fix/Snackbar/mode-dark-use-ColorSchemeProvider

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Snackbar mode="dark" не совпадает с дизайном

Изменения

Используем ColorSchemeProvider

Release notes

Исправления

  • Snackbar: mode="dark" не совпадал с дизайном

@SevereCloud SevereCloud requested a review from a team as a code owner May 19, 2026 14:01
@github-actions github-actions Bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

size-limit report 📦

Path Size
JS 425.68 KB (+0.01% 🔺)
JS (gzip) 131.3 KB (+0.01% 🔺)
JS (brotli) 108.42 KB (+0.13% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 382.69 KB (-0.05% 🔽)
CSS (gzip) 46.9 KB (-0.05% 🔽)
CSS (brotli) 37.04 KB (+0.07% 🔺)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 3b89be7

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9834/3b89be7ca0d327ef508c501afe141e061b9e8214/pkg/@vkontakte/vkui/_pkg.tgz

Commit 3b89be7

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.22%. Comparing base (8947bfd) to head (3b89be7).

Files with missing lines Patch % Lines
.../components/Snackbar/subcomponents/Basic/Basic.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9834      +/-   ##
==========================================
- Coverage   95.22%   95.22%   -0.01%     
==========================================
  Files         462      462              
  Lines       12514    12516       +2     
  Branches     4478     4478              
==========================================
+ Hits        11917    11918       +1     
- Misses        597      598       +1     
Flag Coverage Δ
unittests 95.22% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/Snackbar/mode-dark-use-ColorSchemeProvider branch from 21e1b3c to 361dd2b Compare May 19, 2026 14:23
@qurle
Copy link
Copy Markdown
Contributor

qurle commented May 20, 2026

а поч шрифты слетели

image

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 27, 2026
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/Snackbar/mode-dark-use-ColorSchemeProvider branch from 361dd2b to 3b89be7 Compare May 29, 2026 09:18
@vkcom-publisher vkcom-publisher removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants