-
Notifications
You must be signed in to change notification settings - Fork 198
fix: cache Intl #9340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: cache Intl #9340
Conversation
size-limit report 📦
|
e2e tests
|
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9340/cb4b24fc702e13ff85d2d2579e704b8d9c315f40/pkg/@vkontakte/vkui/_pkg.tgzCommit cb4b24f |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9340 +/- ##
==========================================
+ Coverage 94.71% 94.72% +0.01%
==========================================
Files 439 440 +1
Lines 11866 11897 +31
Branches 4385 4386 +1
==========================================
+ Hits 11239 11270 +31
Misses 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Дизайн-ревьюДокументация фичиОписание
Инициализация Intl занимает некоторое время
https://www.measurethat.net/Benchmarks/Show/32387/0/cached-intlnumberformat-vs-new-intlnumberformat-vs-tolo
Изменения
Кэшируем Intl функции
Release notes
Улучшения