Merged
Conversation
…in adc.c (#7233) compatibility fix for newer avr-libc - define stack pointer add missing avr/io.h include to adc.c add missing avr/io.h include to spi.c Signed-off-by: Nicolás Méndez <9phhsyrbm@relay.firefox.com>
Rework the code slightly to avoid an expensive software divide when calculating the rate in i2c.c . Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
…ce.md Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Add a new create_probe_result() helper function that can generate a ProbeResult using a toolhead position and a set of probe offsets. Use this helper in other modules. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
The config option 'z_offset' name is confusing as its behavior is notably different from how other probe hardware uses 'z_offset'. Rename to 'descend_z' to make its behavior more clear. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Theoretically a "tap" probe should detect the exact point that the nozzle contacts the bed. In practice, however, there can be a systemic bias that one may wish to account for. This bias may be due to backlash, thermal expansion, a detection bias, or similar issues. Add a new tap_z_offset config parameter to allow users to specify an offset. Also, update the Z_OFFSET_APPLY_PROBE command to support modifying this value. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
…nd "tap" Add a new EddyParameterHelper to override ProbeParameterHelper. Only use the printer.cfg lift_speed, samples, sample_retract_dist, samples_result, samples_tolerance, and samples_tolerance_retries settings for normal probe operations. Don't use these defaults when using a "METHOD" set to "scan", "rapid_scan", or "tap". Each of these probing mechanisms is distinct and it's unlikely a user could meaningfully set a default for all of them. Don't set sample_retract_dist when using "scan" and "rapid_scan" modes. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Perform lifting at the end of EddyTap.run_probe(). This is in preparation for performing tap analysis during retraction. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Don't calculate the nozzle/bed contact position from the descent movement. Instead, obtain the data during the lifting movement and determine the contact point by analyzing where the nozzle separates from the bed. This improves the precision and repeatability of the "tap" results. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.