Refactor: Device refactor to integrate Platform-Devices #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
n-eiling
approved these changes
Aug 21, 2024
IgnoreWarnings
changed the title
IgnoreWarnings
changed the title
IgnoreWarnings
force-pushed
the
refactor-pci
branch
2 times, most recently
from
1eb8d83 to
d4015e8
Compare
Member
|
@stv0g we are waiting for your approval :) |
Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de>
Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de>
Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de>
Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de>
Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de>
Contributor
|
Glaube da sind irgendwie Zertifikate in der CI abgelaufen: |
stv0g
requested changes
Aug 30, 2024
Contributor
stv0g
left a comment
stv0g
left a comment
There was a problem hiding this comment.
Looks good to me :) Could you rename pci_device.hpp to just pci.hpp, fix the CI and remove to one superfluous parantheses?
Thanks :) 👍🏻
Member
|
I guess it was fixed. I fixed the CI by rerunning it. |
Collaborator
Author
@n-eiling Can you fix this? |
stv0g
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename (pci::)Device to PciDevice and move it to devices folder. Change DeviceList to PciDeviceList. Change namespace from pci to devices.
#808 Introduces a Device interface which will integrate Pci Devices and Platform Devices.