Generalize proxy external auth #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2025
stv0g
reviewed
Oct 16, 2025
| {{- end }} | ||
| nginx.ingress.kubernetes.io/rewrite-target: /$1 | ||
| nginx.ingress.kubernetes.io/use-regex: "true" | ||
| nginx.ingress.kubernetes.io/proxy-body-size: 1024m |
Contributor
There was a problem hiding this comment.
I think this was necessary to upload larger files, e.g. CSV results which are pushed to VILLASweb.
Contributor
|
I dont have the time for testing this unfortunately. But I think we can go ahead and merge it. Could you maybe check if a configuration without IDP still works? |
Author
|
@stv0g What do you mean exactly without IDP? Wihtout external auth? |
added 3 commits
October 27, 2025 09:18
…s image Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
SystemsPurge
force-pushed
the
proxy-test
branch
from
257a6e3 to
87cd4bf
Compare
Contributor
|
Yes exactly, just normal auth via VILLASwebs database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the seperate flow urls (login,validate...etc) with a single issuer url that defines which flows the IDP supports, making the possible authentication methods supported by the proxy more flexible and IDP dependent.
Added code_challenge_method (PKCE) environment, in case the IDP cannot explicitely provide a secret.
Kept the client_secret env, in case the IDP is able to explicitely add villas as a client.
Changed ingress proxy annotations to account for headers possibly being too big with some auth flows.
If wou want to test, use a keycloak instance ( as an example ), with
KC_PROXY=edgeandKC_PROXY_HEADERS=xforwardedBoth the public and confidential client configurations should work properly.