Skip to content

add failsafe to embed logic to handle the unlikely edge case of embeds loading faster than alpine can react to it#961

Open
justinkluever wants to merge 1 commit into
masterfrom
justink/clip-loader-failsafe
Open

add failsafe to embed logic to handle the unlikely edge case of embeds loading faster than alpine can react to it#961
justinkluever wants to merge 1 commit into
masterfrom
justink/clip-loader-failsafe

Conversation

@justinkluever

@justinkluever justinkluever commented Jun 28, 2026

Copy link
Copy Markdown
Member

we basically mark the iframe as loaded via native javascript so alpine can later pick it up and use that instead for waiting for a potentially never firing load event as it may be already loaded before alpine even initializes.

because of how it works i have limited it to only a few miliseconds after init as we should be safe to assume that either something is broken or the iframe is actually still loading and will fire the event anyway

we basically mark the iframe as loaded via native javascript so alpine can later pick it up and use that instead for waiting for a potentially never firing load event as it _may_ be already loaded before alpine even initializes.
@justinkluever justinkluever added bug Something isn't working frontend Frontend Design Size: Very Small This is considered very fast to Review/Implement (usually <50+) labels Jun 28, 2026
@justinkluever justinkluever changed the title add failsafe for a possible but unlikely edge case to base embed logic add failsafe to embed logic to handle the unlikely edge case of embeds loading faster than alpine can react to it Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend Frontend Design Size: Very Small This is considered very fast to Review/Implement (usually <50+)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant