add failsafe to embed logic to handle the unlikely edge case of embeds loading faster than alpine can react to it#961
Open
justinkluever wants to merge 1 commit into
Open
Conversation
we basically mark the iframe as loaded via native javascript so alpine can later pick it up and use that instead for waiting for a potentially never firing load event as it _may_ be already loaded before alpine even initializes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we basically mark the iframe as loaded via native javascript so alpine can later pick it up and use that instead for waiting for a potentially never firing load event as it may be already loaded before alpine even initializes.
because of how it works i have limited it to only a few miliseconds after init as we should be safe to assume that either something is broken or the iframe is actually still loading and will fire the event anyway