fix: explicit NegWeightTreatment=Pray for BoostType=Grad in TMVA angular training#357
Merged
Conversation
…lar training BoostType=Grad does not support InverseBoostNegWeights (TMVA's global default for BDT), which caused TMVA to silently replace it with Pray, making the effective training configuration differ from the nominal one. Explicitly setting NegWeightTreatment=Pray in the default options string eliminates the silent substitution and ensures the logged configuration matches actual training behaviour. Fixes: #352 (item from mvaAngRes log) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the default TMVA angular reconstruction BDT configuration explicit about negative weight handling so the recorded option string matches the behavior used with BoostType=Grad.
Changes:
- Adds
NegWeightTreatment=Prayto the default TMVA options string. - Documents why the option is explicit for gradient-boosted BDT training.
- Adds a bugfix changelog fragment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/trainTMVAforAngularReconstruction.cpp |
Updates the default TMVA BDT options and explanatory comment. |
docs/changes/353.bugfix.md |
Adds a changelog entry describing the explicit negative weight treatment fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoostType=Grad does not support InverseBoostNegWeights (TMVA BDT global default), causing a silent replacement with Pray and a mismatch between nominal and effective training configuration. Adds the explicit option to the default string.