v492 13 mva g/h separation #336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on improvements to the TMVA (Toolkit for Multivariate Analysis) gamma/hadron separation functionality, specifically enhancing interpolation from average zenith angle to average airmass calculations.
Key changes:
- Improved TMVA interpolation to use airmass-weighted zenith angle calculations instead of simple averaging
- Removed deprecated smoothing and interpolation functionality for MVA cut values
- Cleaned up unused parameters and obsolete code related to box smoothing and TMVA optimization
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/writeParticleRateFilesForTMVA.cpp | Deleted - entire file removed (164 lines) |
| src/trainTMVAforGammaHadronSeparation.cpp | Renamed method calls from getTLRunParameter to getTableLookupRunParameters for clarity |
| src/calculateCrabRateFromMC.cpp | Updated documentation, renamed function for consistency, changed pointer to stack object for VMonteCarloRateCalculator |
| src/VTMVARunData.cpp | Renamed method getTLRunParameter to getTableLookupRunParameters |
| src/VTMVAEvaluator.cpp | Major refactoring: removed smoothing/interpolation functions, updated plotting to support multiple zenith bins, improved airmass calculation, removed unused methods |
| src/VStereoMaps.cpp | Removed box smoothing feature, simplified theta2 cut logic |
| src/VGammaHadronCuts.cpp | Removed TMVACUTS parameter parsing and related unused member variables |
| src/VAnaSumRunParameter.cpp | Removed fNBoxSmooth parameter |
| macros/optimizeBDTcuts.C | Updated plotSignalAndBackgroundEfficiencies call with explicit parameters |
| inc/VTMVARunData.h | Updated method declaration and incremented ClassDef version |
| inc/VTMVAEvaluator.h | Removed smoothing-related methods and member variables, updated return type, incremented ClassDef version |
| inc/VInstrumentResponseFunctionRunParameter.h | Incremented ClassDef version |
| inc/VGammaHadronCuts.h | Removed unused TMVA optimization member variables |
| inc/VAnaSumRunParameter.h | Removed fNBoxSmooth member and incremented ClassDef version |
| docs/changes/336.feature.md | Added changelog entry describing the feature |
| Makefile | Removed build target for writeParticleRateFilesForTMVA |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.