Extensions of LineInformation, StopInformation and TripInformation St… #25

ThomasKling · 2022-09-30T09:22:58Z

…ructure plus Number of Error Messages in DMS reduced from 10 to 0.

ThomasKling · 2022-11-07T12:06:23Z

LineSymbolText redefined to InternationTextType

dirkweisser · 2023-01-04T10:44:10Z

In the document which went through the review process, we deleted in the LineInformationStructure the optional LineCode of type IBIS-IP.int, introduced an optional LineSymbolCode of type IBIS-IP.int and had the LinePublicCode of this PullRequest before the new LineSymbolCode. We either had to change the document or the xsd.

dirkweisser · 2023-01-04T10:48:43Z

In the document we had in the TripInformationStructure the new BlockNumber before the PatternNumber. We either had to change the document or the xsd.

dirkweisser · 2023-01-04T12:03:31Z

IBIS-IP_common_V2.4.xsd

+				</xs:annotation>
+			</xs:element>
+			<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>


Suggested change

<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>

<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>

<xs:annotation>

<xs:documentation>Short name of the stop in the planning program and ITCS. To identify a stop on media with limited display length, e.g. older interior displays, on-board computer or ticket printer terminal.

</xs:documentation>

dirkweisser · 2023-01-04T12:08:40Z

IBIS-IP_common_V2.4.xsd

+					<xs:documentation>Information on Connections or Interchanges; not in StopSequence because of RealTimeInformation</xs:documentation>
+				</xs:annotation>
+			</xs:element>
+			<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>


Suggested change

<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>

<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>

<xs:annotation>

<xs:documentation>Valid fare zone at this stop point</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:09:40Z

IBIS-IP_common_V2.4.xsd

+			</xs:element>
+			<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>

<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation>Stop number that is used throughout the transport association (PTA) for activation of ticket printers and ticket validators. This number is not necessarily unique and is only used for stops that are used productively. This number is not required for non-productive stops (e.g. depots, parking facilities, car parks).

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:10:23Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="FareZone" type="IBIS-IP.NMTOKEN" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>			
+			<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>

<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation>Transport company-wide internal unique number of a stopping point in the network.

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:11:20Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="StopShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="StopLongNo" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>			
+			<xs:element name="PointNumber" type="IBIS-IP.int" minOccurs="0" maxOccurs="1"/>			
+			<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:element name="StopGlobalID" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation>International stop ID e.g. in Germany according to VDV432 (DHID), internationally according to NeTEx, NAPTAN.

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:17:08Z

IBIS-IP_common_V2.4.xsd

+				</xs:annotation>
+			</xs:element>
+			<xs:element name="BlockNumber" type="IBIS-IP.int"  minOccurs="0" maxOccurs="1"/>						
+			<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string"  minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:element name="ExternalVehicleJourneyRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation>

International trip ID e.g. in Germany according to VDV433 (DFID), internationally according to NeTEx.

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:19:49Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="LineName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="LineShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
+			<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">


Suggested change

<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">

<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">

<xs:annotation>

<xs:documentation>Unique additional number for displaying symbols or special lines on and in the vehicle. This additional number is used as a supplement to the LineNumber. For example, for the display of symbols such as airport, P+R, school bus or the coding of special lines such as night buses, rail replacement services, substitute lines.

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:23:09Z

IBIS-IP_common_V2.4.xsd

+					<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>
+				</xs:annotation>
+			</xs:element>
+			<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation> Published line identification for the passenger. For displaying the line on all media such as line network maps, timetable printouts, passenger information on the internet, on signs, the stop displays, on the exterior and interior displays of the vehicles.

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:24:22Z

IBIS-IP_common_V2.4.xsd

+				</xs:annotation>
+			</xs:element>
+			<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>			
+			<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>			


Suggested change

<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>

<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>

<xs:annotation>

<xs:documentation>Specification of a xml formatted text to reference an symbol for special lines. Used as alternative to the LineSymbolCode. For example for displaying an airport symbol the following string could be used: <icon type=" airport "> airport </icon>

</xs:documentation>

</xs:annotation>

dirkweisser · 2023-01-04T12:25:10Z

IBIS-IP_common_V2.4.xsd

+			</xs:element>
+			<xs:element name="LinePublicCode" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>			
+			<xs:element name="LineSymbolText" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>			
+			<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>			


Suggested change

<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:element name="ExternalLineRef" type="IBIS-IP.string" minOccurs="0" maxOccurs="1"/>

<xs:annotation>

<xs:documentation>International line ID e.g. in Germany according to VDV433 DLID, internationally according to NeTEx.</xs:documentation>

</xs:annotation>

ThomasKling · 2023-01-04T12:43:48Z

In the xsd the LineCode is available. In a WebCo we have agreed to reuse LineCode and not to rename it. Therefore the document has to be changed. Best regards Thomas Von: Dirk Weißer ***@***.***> Gesendet: Mittwoch, 4. Januar 2023 11:44 An: VDVde/VDV301 ***@***.***> Cc: Thomas Kling ***@***.***>; State change ***@***.***> Betreff: Re: [VDVde/VDV301] Extensions of LineInformation, StopInformation and TripInformation St… (PR #25) EXTERNAL: Do not click links or open attachments if you do not recognize the sender. In the document which went through the review process, we deleted the optional LineCode of type IBIS-IP.int, introduced an optional LineSymbolCode of type IBIS-IP.int and had the LinePublicCode of this PullRequest before the new LineSymbolCode. We either had to change the document or the xsd. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/VDVde/VDV301/pull/25*issuecomment-1370763048__;Iw!!I_DbfM1H!EJwIbRTLfsHYTWHzDJyJ_18dt_GRgomVy0UgQQ9rcNwUNICJKSkAFzQiDvTIQKzQx-BviBIJmi3-Zwa6NcBgqfMoNpyyUyi9$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ANALFIT6TSBNZJ47ZDW24WDWQVIALANCNFSM6AAAAAAQZS2HDE__;!!I_DbfM1H!EJwIbRTLfsHYTWHzDJyJ_18dt_GRgomVy0UgQQ9rcNwUNICJKSkAFzQiDvTIQKzQx-BviBIJmi3-Zwa6NcBgqfMoNsquCrYv$>. You are receiving this because you modified the open/close state.Message ID: ***@***.******@***.***>>

dirkweisser · 2023-01-04T12:47:27Z

ok - changed in my proposal.

What about the order? First LineCode or first LinePublicCode?

dirkweisser · 2023-01-04T13:13:04Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
+				<xs:annotation>
+					<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>
+				</xs:annotation>


Suggested change

</xs:annotation>

dirkweisser · 2023-01-04T13:13:16Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
+			<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
+				<xs:annotation>
+					<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>


Suggested change

<xs:documentation>identifier of a symbol number , which is used by displays see LINIEN_CODE in VDV 452 chapter 9.7.2 REC_LID</xs:documentation>

dirkweisser · 2023-01-04T13:13:32Z

IBIS-IP_common_V2.4.xsd

+			<xs:element name="LineShortName" type="InternationalTextType" minOccurs="0" maxOccurs="unbounded"/>
+			<xs:element name="LineNumber" type="IBIS-IP.int" minOccurs="0"/>
+			<xs:element name="LineCode" type="IBIS-IP.int" minOccurs="0">
+				<xs:annotation>


Suggested change

<xs:annotation>

ThomasKling and others added 2 commits September 29, 2022 09:14

Extensions of LineInformation, StopInformation and TripInformation St…

43222a7

…ructure plus Number of Error Messages in DMS reduced from 10 to 0.

Update IBIS-IP_common_V2.4.xsd

8002478

ThomasKling closed this Nov 7, 2022

ThomasKling reopened this Nov 7, 2022

dirkweisser self-assigned this Dec 29, 2022

dirkweisser reviewed Jan 4, 2023

View reviewed changes

RicoBiedermann self-requested a review April 9, 2024 07:31

RicoBiedermann unassigned dirkweisser Apr 9, 2024

Extensions of LineInformation, StopInformation and TripInformation St… #25

Are you sure you want to change the base?

Extensions of LineInformation, StopInformation and TripInformation St… #25

Uh oh!

Conversation

ThomasKling commented Sep 30, 2022

Uh oh!

ThomasKling commented Nov 7, 2022

Uh oh!

dirkweisser commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dirkweisser commented Jan 4, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dirkweisser Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dirkweisser Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ThomasKling commented Jan 4, 2023 via email

Uh oh!

dirkweisser commented Jan 4, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dirkweisser commented Jan 4, 2023 •

edited

Loading

dirkweisser Jan 4, 2023 •

edited

Loading

dirkweisser Jan 4, 2023 •

edited

Loading