Pca#102
Open
necrolyte2 wants to merge 21 commits intomasterfrom
Open
Conversation
…nalysis. Will convert to regular python
…d optionally output file location
…s. Can supply substitution matrix on command line. Fixed bug with unindexed dataframe which was very slow
… as I was not getting them. By default they go to the commit author
Contributor
|
The alternative lives here: #43 I never re-opened that PR against master. |
Member
Author
|
It seems that the other PR is better as it utilizes emperor which if I remember correctly was just better overall? |
Contributor
|
that's what we decided at the time. I'll re-open that PR. I wouldn't want to lose this code altogether, though, as it might be useful later, even if just as a reference. Maybe just not delete the branch? |
Member
Author
|
I don't like 'dirty' branches haha, but ya. I would just leave this PR open then with these comments otherwise might forget later why that branch exists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not even sure what this branch was about, but putting up so we can review and what not