Skip to content

disclose property if readonly and the options lists #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wawashra merged 2 commits into from
Feb 10, 2026
Merged

disclose property if readonly and the options lists #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a95807d
disclose property if readonly and the options lists
wawashra Feb 8, 2026
7fba118
Fix pros fetch
wawashra Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/hubspot/manage/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"tickets"
]

@plural_standard_objects_types [

Check warning on line 42 in lib/hubspot/manage/client.ex

View workflow job for this annotation

GitHub Actions / Compile code 

module attribute @plural_standard_objects_types was set but never used

Check warning on line 42 in lib/hubspot/manage/client.ex

View workflow job for this annotation

GitHub Actions / Dialyzer static analysis 

module attribute @plural_standard_objects_types was set but never used
"contacts",
"companies",
"deals",
Expand Down Expand Up @@ -687,18 +687,16 @@
|> Enum.map_join("&", fn {key, val} -> "#{key}=#{val}" end)
end

defp to_property(property),
do: %{
defp to_property(property) do
%{
id: property["name"],
title: property["label"],
is_custom_property:
if property["hubspotDefined"] do
false
else
true
end,
type: property["type"]
is_custom_property: not property["hubspotDefined"],
type: property["type"],
options: property["options"],
is_read_only: property["modificationMetadata"]["readOnlyValue"]
}
end

defp eventable?(_object_name, :custom_object), do: true

Expand Down
Loading