Skip to content

handle errors from ExForce.versions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mujahed-odeh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

handle errors from ExForce.versions #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/salesforce.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ defmodule Salesforce do
# Authentication Response Example:
# {:ok,
# %ExForce.OAuthResponse{
# access_token: "00DDp0000018Wr2!AQEAQDV4NO.YPKFZSFV38KxZAnDxVZX6wWV67isrYI124_3tbvJsFAnZwuS05hY0ElkIl_0rSvOBM2dc454I9DkPwPm7COBp",
# access_token: "***************",
# id: "https://login.salesforce.com/id/00DDp0000018Wr2MAE/005Dp000002NCZXIA4",
# instance_url: "https://userpilot-dev-ed.develop.my.salesforce.com",
# issued_at: ~U[2023-11-07 13:19:11.832Z],
Expand Down Expand Up @@ -170,8 +170,8 @@ defmodule Salesforce do
code: code,
code_verifier: code_verifier,
code_challenge_method: code_challenge_method
) do
{:ok, version_maps} = ExForce.versions(instance_url)
),
{:ok, version_maps} <- ExForce.versions(instance_url) do
latest_version = version_maps |> Enum.map(&Map.fetch!(&1, "version")) |> List.last()

with client = ExForce.build_client(oauth_response, api_version: latest_version),
Expand Down Expand Up @@ -213,8 +213,8 @@ defmodule Salesforce do
client_id: client_id,
client_secret: client_secret,
refresh_token: refresh_token
) do
{:ok, version_maps} = ExForce.versions(instance_url)
),
{:ok, version_maps} <- ExForce.versions(instance_url) do
latest_version = version_maps |> Enum.map(&Map.fetch!(&1, "version")) |> List.last()

client = ExForce.build_client(oauth_response, api_version: latest_version)
Expand Down