feat: add exchange and broadcast in memory buffer#219
Merged
Conversation
deepaksftc
approved these changes
Oct 24, 2025
Contributor
|
@TCMeldrum What happens if i have two instances of backend running? Will it have two memory buffers and hence send the message 2x times? |
Contributor
Author
|
They would yeah but the events sent to the rabbitmq message broker should be inderpendent as they come from the backends events handler. E.g. when a proposal is submitted the proposal submitted event will only exist within the backend that resieved the request. It will then store the event in the buffer until that backend reconnects. This is mostly to cover the case where rabbitmq is unavilible. Does that make sense sorry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1485
Description
Add more buffers like message buffer so if rabbitmq goes down but the backend stays alive broadcasts and messages to exchanges are not lost. I have also added logging to show how many messages are waiting to be sent.
The messages will still be lost if the backend restarts but this adds a small layer of resiliance that would have helpped during our call deadline where a proposals was submitted in a 2 min window when rabbitmq restarted
Motivation and Context
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?