Remove SYS_ADMIN capability from factory#5
Open
joeshannon wants to merge 1 commit intoUserOfficeProject:developfrom
Open
Remove SYS_ADMIN capability from factory#5joeshannon wants to merge 1 commit intoUserOfficeProject:developfrom
joeshannon wants to merge 1 commit intoUserOfficeProject:developfrom
Conversation
This doesn't appear to be required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove SYS_ADMIN capability from factory
Motivation and Context
When deploying this to our k8s cluster our infrastructure team raised some concern over this and it was unclear to us if it was actually required.
How Has This Been Tested
The chart has been successfully deployed with this change and basic testing performed (downloading a proposal pdf) however more extensive testing may be required.