fix: call order is not persistent for user officers#1294
Merged
ellen-wright merged 14 commits intodevelopfrom Feb 13, 2026
Merged
fix: call order is not persistent for user officers#1294ellen-wright merged 14 commits intodevelopfrom
ellen-wright merged 14 commits intodevelopfrom
Conversation
ellen-wright
requested review from
William-Edwards-STFC and
deepaksftc
and removed request for
a team and
William-Edwards-STFC
| ); | ||
| setCalls(callsWithUpdatedOrder); | ||
| setCalls( | ||
| callsWithUpdatedOrder.sort((a, b) => |
Contributor
There was a problem hiding this comment.
question: do you know why callsWithUpdatedOrder is already not in the right order and need to be sorted again?
Contributor
There was a problem hiding this comment.
I mean do we even need to call
const callsWithUpdatedOrder = reorder(
calls,
result.source.index,
result.destination.index
);
…ffice-core into 1473-fix-call-ordering-persistence-bug
…ffice-core into 1473-fix-call-ordering-persistence-bug
…ub.com/UserOfficeProject/user-office-core into 1473-fix-call-ordering-persistence-bug
…ub.com/UserOfficeProject/user-office-core into 1473-fix-call-ordering-persistence-bug
Contributor
jekabs-karklins
left a comment
jekabs-karklins
left a comment
There was a problem hiding this comment.
Just one more suggestion I just noticed WDYT. Otherwise looks good!
jekabs-karklins
approved these changes
Feb 13, 2026
Scott-James-Hurley
approved these changes
Feb 13, 2026
Contributor
Scott-James-Hurley
left a comment
Scott-James-Hurley
left a comment
There was a problem hiding this comment.
Maybe a couple of e2e tests should be added to check if the order is persisted on the call ordering and when creating a new proposals?
yoganandaness
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: Farai Mutambara <71100224+mutambaraf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refs: UserOfficeProject/issue-tracker#1473
Fixes the bug where the order selected by User Officers for the calls is not persistent when they close the order editor and reopen.
When the calls are required to be ordered the ordering is done in the backend.
A ordered flag is added to calls filter.
Motivation and Context
This was a bug