fix: refactor institution handling in user authorization and mutations [WIP]#1289
Draft
jekabs-karklins wants to merge 10 commits intodevelopfrom
Draft
fix: refactor institution handling in user authorization and mutations [WIP]#1289jekabs-karklins wants to merge 10 commits intodevelopfrom
jekabs-karklins wants to merge 10 commits intodevelopfrom
Conversation
jekabs-karklins
requested review from
Scott-James-Hurley
and removed request for
a team
jekabs-karklins
changed the title
…gging created institution ID
…nd for user upsert
jekabs-karklins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the handling of institutions in user authorization and mutations, allowing for more robust and flexible management of user institutions.
Motivation and Context
This change is required to better handle situations where institution data is provided in different formats or from different sources. It aims to streamline the process of associating users with institutions, improving the overall user management workflow.
Changes
getOrCreateUserInstitutionmethod inOAuthAuthorizationto accept different types of input (ROR ID, manual input, institution ID), and split into smaller, more specific methods.getOrCreateUserInstitutionmethod inStfcUserAuthorizationto match the new input type.getOrCreateUserInstitutionmethod inUserAuthorizationto match the new input type.How Has This Been Tested
Unit tests have been updated and run to ensure the changes work as expected. Additionally, manual testing has been performed to verify correct functionality in a live environment.
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-5157
Depends On
Tests included/Docs Updated?